Clear object names list on initialization #4259
Open
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in RigidObjectCollection where _object_names_list accumulates duplicate entries when the simulation resets multiple times, leading to incorrect object counts.
Fixes # (4258)
Problem:
When using workflows that trigger multiple simulation resets (e.g.,
record_demos.py), the_initialize_impl()method gets called multiple times without clearing the existing_object_names_list, causing duplicate object names to be appended.Solution:
Added
self._object_names_list.clear()at the beginning of_initialize_impl()to ensure the list is reset before repopulating it, making the initialization process idempotent.Test Command:
Type of change
Screenshots
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there