Skip to content

Assignment 2 complete#2

Open
vbrejkaln wants to merge 2 commits intomainfrom
assignment-two
Open

Assignment 2 complete#2
vbrejkaln wants to merge 2 commits intomainfrom
assignment-two

Conversation

@vbrejkaln
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one change required:
Please replace the hardcoded absolute paths to relative paths so that a Learning support can run the code successfully as well. For example: change "/Users/vbrej/python/05_src/data/assignment_2_data/inflammation_01.csv" to "../../05_src/data/assignment_2_data/inflammation_01.csv"

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed now, Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants