-
Notifications
You must be signed in to change notification settings - Fork 0
Deploy: Merge to main #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Feature/13 user
* feat : google login ๊ตฌํ ์๋ฃ (ios ๊ตฌํ ์ค)
* feat : google login ๊ตฌํ ์๋ฃ * fix : user hard delete * feat : apple ๋ก๊ทธ์ธ ๊ตฌํ ๋ฐ ddl-auto -> update ๋ณ๊ฒฝ
|
Caution Review failedThe pull request is closed. WalkthroughApple ID ํ ํฐ ๊ฒ์ฆ ๊ธฐ๋ฅ์ด ๊ตฌํ๋์์ต๋๋ค. AuthService์ Sequence DiagramsequenceDiagram
actor Client
participant AuthService
participant JwtDecoder
participant Claims
participant AuthErrorCode
Client->>AuthService: getEmailFromIdToken(appleIdToken)
rect rgb(200, 220, 240)
Note over AuthService,JwtDecoder: Apple JWT ํ ํฐ ๊ฒ์ฆ
AuthService->>JwtDecoder: decode(token)
end
alt JwtException ๋ฐ์
JwtDecoder-->>AuthService: JwtException
AuthService->>AuthErrorCode: INVALID_TOKEN
AuthService-->>Client: Error: INVALID_TOKEN
else ํ ํฐ ๋์ฝ๋ฉ ์ฑ๊ณต
JwtDecoder-->>AuthService: Jwt ๊ฐ์ฒด
rect rgb(220, 240, 200)
Note over AuthService,Claims: ๋ฐ๊ธ์ฌ ๋ฐ ๋์์ ๊ฒ์ฆ
AuthService->>Claims: getClaim("iss")
AuthService->>Claims: getClaim("aud")
end
alt ๋ฐ๊ธ์ฌ/๋์์ ๋ถ์ผ์น
AuthService->>AuthErrorCode: APPLE_LOGIN_ERROR
AuthService-->>Client: Error: APPLE_LOGIN_ERROR
else ๊ฒ์ฆ ์ฑ๊ณต
rect rgb(240, 240, 200)
Note over AuthService,Claims: ์ด๋ฉ์ผ ์ถ์ถ
AuthService->>Claims: getClaimAsString("email")
end
alt ์ด๋ฉ์ผ ์์
AuthService-->>Client: NOT_EXISTS_EMAIL
else ์ด๋ฉ์ผ ์กด์ฌ
AuthService-->>Client: email
end
end
end
Possibly related PRs
โจ Finishing touches
๐งช Generate unit tests (beta)
๐ Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ๐ Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
๐ ์์ธ ๋ด์ฉ
๐ ๊ด๋ จ ์ด์
Summary by CodeRabbit
New Features
Chores
โ๏ธ Tip: You can customize this high-level summary in your review settings.