Skip to content

Conversation

@yyytir777
Copy link
Contributor

@yyytir777 yyytir777 commented Dec 16, 2025

๐Ÿ“ ์ƒ์„ธ ๋‚ด์šฉ

  • ๊ตฌ๊ธ€ ๋ฐ ์• ํ”Œ ๋กœ๊ทธ์ธ ๊ตฌํ˜„

๐Ÿ”— ๊ด€๋ จ ์ด์Šˆ

Summary by CodeRabbit

  • New Features

    • Apple ID ํ† ํฐ ๊ฒ€์ฆ ๋ฐ ์ด๋ฉ”์ผ ์ถ”์ถœ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • Chores

    • CI/CD ๋ฐฐํฌ ํŒŒ์ดํ”„๋ผ์ธ ๊ตฌ์„ฑ ๊ฐœ์„ 
    • ์ธ์ฆ ์„ค์ • ๊ตฌ์กฐ ์—…๋ฐ์ดํŠธ (Naver ํ†ตํ•ฉ ์ œ๊ฑฐ, Google ์„ค์ • ๊ฐ•ํ™”)
    • ์—๋Ÿฌ ์ฒ˜๋ฆฌ ๋ฐ ์ž…๋ ฅ ์œ ํšจ์„ฑ ๊ฒ€์‚ฌ ๊ฐœ์„ 

โœ๏ธ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 16, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Apple ID ํ† ํฐ ๊ฒ€์ฆ ๊ธฐ๋Šฅ์ด ๊ตฌํ˜„๋˜์—ˆ์Šต๋‹ˆ๋‹ค. AuthService์˜ getEmailFromIdToken ๋ฉ”์„œ๋“œ์—์„œ Apple JWT๋ฅผ ๋””์ฝ”๋”ฉํ•˜๊ณ , ๋ฐœ๊ธ‰์‚ฌ์™€ ๋Œ€์ƒ์ž๋ฅผ ๊ฒ€์ฆํ•œ ํ›„ ์ด๋ฉ”์ผ์„ ์ถ”์ถœํ•ฉ๋‹ˆ๋‹ค. ๊ด€๋ จ ์—๋Ÿฌ ์ฝ”๋“œ ๋ฐ ์ž…๋ ฅ ๊ฒ€์ฆ ๊ทœ์น™์ด ์ถ”๊ฐ€๋˜์—ˆ๊ณ , CI/CD ํŒŒ์ดํ”„๋ผ์ธ ์„ค์ •๊ณผ ํ™˜๊ฒฝ๋ณ„ ์„ค์ • ํŒŒ์ผ์ด ์—…๋ฐ์ดํŠธ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

Sequence Diagram

sequenceDiagram
    actor Client
    participant AuthService
    participant JwtDecoder
    participant Claims
    participant AuthErrorCode

    Client->>AuthService: getEmailFromIdToken(appleIdToken)
    
    rect rgb(200, 220, 240)
    Note over AuthService,JwtDecoder: Apple JWT ํ† ํฐ ๊ฒ€์ฆ
    AuthService->>JwtDecoder: decode(token)
    end
    
    alt JwtException ๋ฐœ์ƒ
        JwtDecoder-->>AuthService: JwtException
        AuthService->>AuthErrorCode: INVALID_TOKEN
        AuthService-->>Client: Error: INVALID_TOKEN
    else ํ† ํฐ ๋””์ฝ”๋”ฉ ์„ฑ๊ณต
        JwtDecoder-->>AuthService: Jwt ๊ฐ์ฒด
        
        rect rgb(220, 240, 200)
        Note over AuthService,Claims: ๋ฐœ๊ธ‰์‚ฌ ๋ฐ ๋Œ€์ƒ์ž ๊ฒ€์ฆ
        AuthService->>Claims: getClaim("iss")
        AuthService->>Claims: getClaim("aud")
        end
        
        alt ๋ฐœ๊ธ‰์‚ฌ/๋Œ€์ƒ์ž ๋ถˆ์ผ์น˜
            AuthService->>AuthErrorCode: APPLE_LOGIN_ERROR
            AuthService-->>Client: Error: APPLE_LOGIN_ERROR
        else ๊ฒ€์ฆ ์„ฑ๊ณต
            rect rgb(240, 240, 200)
            Note over AuthService,Claims: ์ด๋ฉ”์ผ ์ถ”์ถœ
            AuthService->>Claims: getClaimAsString("email")
            end
            
            alt ์ด๋ฉ”์ผ ์—†์Œ
                AuthService-->>Client: NOT_EXISTS_EMAIL
            else ์ด๋ฉ”์ผ ์กด์žฌ
                AuthService-->>Client: email
            end
        end
    end
Loading

Possibly related PRs

  • PR #32: ๋™์ผํ•œ auth ๊ด€๋ จ ํŒŒ์ผ(GoogleAndAppleSignupRequest, AuthService, AuthErrorCode, application configs)์„ ์ˆ˜์ •ํ•˜์—ฌ Apple ๋กœ๊ทธ์ธ ๋ฐ ๊ด€๋ จ ๊ฒ€์ฆ/์—๋Ÿฌ ์ฒ˜๋ฆฌ๋ฅผ ์ถ”๊ฐ€ํ•ฉ๋‹ˆ๋‹ค.
  • PR #30: AuthService์˜ Apple ํ† ํฐ ์ฒ˜๋ฆฌ ๋ฐ ๊ฒ€์ฆ์„ ํ™•์žฅํ•˜๊ณ , GoogleAndAppleSignupRequest์™€ AuthErrorCode์˜ ๋™์ผํ•œ ํŒŒ์ผ์„ ์ˆ˜์ •ํ•ฉ๋‹ˆ๋‹ค.
  • PR #27: AuthErrorCode ์—ด๊ฑฐํ˜•์„ ์ˆ˜์ •ํ•˜๋ฉฐ, ์ด PR์—์„œ NOT_EXISTS_EMAIL์„ ์ถ”๊ฐ€ํ•˜๋Š” ๊ฒƒ๊ณผ ์ฝ”๋“œ ๋ ˆ๋ฒจ์—์„œ ๊ด€๋ จ์ด ์žˆ์Šต๋‹ˆ๋‹ค.
โœจ Finishing touches
  • ๐Ÿ“ Generate docstrings
๐Ÿงช Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

๐Ÿ“œ Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 638843f and b5c29db.

๐Ÿ“’ Files selected for processing (8)
  • .github/workflows/ci-cd.yml (1 hunks)
  • src/main/java/ita/tinybite/domain/auth/dto/request/GoogleAndAppleSignupRequest.java (2 hunks)
  • src/main/java/ita/tinybite/domain/auth/service/AuthService.java (3 hunks)
  • src/main/java/ita/tinybite/global/config/FcmConfig.java (1 hunks)
  • src/main/java/ita/tinybite/global/exception/errorcode/AuthErrorCode.java (1 hunks)
  • src/main/resources/application-dev.yaml (1 hunks)
  • src/main/resources/application-local.yaml (1 hunks)
  • src/main/resources/application.yaml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yyytir777 yyytir777 merged commit 7ec238c into main Dec 16, 2025
@coderabbitai coderabbitai bot mentioned this pull request Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants