Skip to content

Conversation

@yyytir777
Copy link
Contributor

@yyytir777 yyytir777 commented Dec 24, 2025

๐Ÿ“ ์ƒ์„ธ ๋‚ด์šฉ

Summary by CodeRabbit

๋ฆด๋ฆฌ์Šค ๋…ธํŠธ

  • ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ

    • Google ๋ฐ Apple ํšŒ์›๊ฐ€์ž… ์‹œ ์•ฝ๊ด€ ๋™์˜ ๊ฒ€์ฆ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • Chores

    • CI/CD ์›Œํฌํ”Œ๋กœ์šฐ ์—…๋ฐ์ดํŠธ
    • ๋ฐ์ดํ„ฐ๋ฒ ์ด์Šค ์„ค์ • ๋ณ€๊ฒฝ
    • ํ…Œ์ŠคํŠธ ์ธํ”„๋ผ ๊ฐœ์„ 

โœ๏ธ Tip: You can customize this high-level summary in your review settings.

yyytir777 and others added 19 commits December 8, 2025 10:50
* feat : google login ๊ตฌํ˜„ ์™„๋ฃŒ (ios ๊ตฌํ˜„ ์ค‘)
* feat : google login ๊ตฌํ˜„ ์™„๋ฃŒ
* fix : user hard delete
* feat : apple ๋กœ๊ทธ์ธ ๊ตฌํ˜„ ๋ฐ ddl-auto -> update ๋ณ€๊ฒฝ
* ์•ฝ๊ด€ ์—”ํ‹ฐํ‹ฐ ์ƒ์„ฑ ๋ฐ ์—ฐ๊ด€๊ด€๊ณ„ ์„ค์ •

* ํšŒ์›๊ฐ€์ž…์— ์•ฝ๊ด€ ์ €์žฅ ๋กœ์ง ์ถ”๊ฐ€

* ์„œ๋ฒ„์—์„œ idToken์„ ๋ฐ›์•„์˜ฌ ์ˆ˜ ์—†์œผ๋ฏ€๋กœ ๋‹จ์ˆœํžˆ ์ด๋ฉ”์ผ๋กœ accessToken์„ ๋ฐ›์•„์˜ค๋Š” test API ์ถ”๊ฐ€
@coderabbitai
Copy link

coderabbitai bot commented Dec 24, 2025

Caution

Review failed

The pull request is closed.

๐Ÿ“ Walkthrough

Walkthrough

์ด ํ’€ ์š”์ฒญ์€ Google ๋ฐ Apple ๊ฐ€์ž… ํ๋ฆ„์— ์•ฝ๊ด€(Term) ๋™์˜ ๊ธฐ๋Šฅ์„ ์ถ”๊ฐ€ํ•ฉ๋‹ˆ๋‹ค. ์š”์ฒญ DTO์— ๋™์˜ํ•œ ์•ฝ๊ด€ ๋ชฉ๋ก ํ•„๋“œ๋ฅผ ์ถ”๊ฐ€ํ•˜๊ณ , ์ƒˆ๋กœ์šด Term ๋ฐ UserTermAgreement ์—”ํ‹ฐํ‹ฐ๋ฅผ ๋„์ž…ํ•˜์—ฌ ์‚ฌ์šฉ์ž-์•ฝ๊ด€ ๋งคํ•‘์„ ๊ด€๋ฆฌํ•ฉ๋‹ˆ๋‹ค. AuthService์˜ googleSignup ๋ฉ”์„œ๋“œ๋Š” ์ œ๊ณต๋œ ์•ฝ๊ด€์„ ๋ฐ์ดํ„ฐ๋ฒ ์ด์Šค์—์„œ ๊ฒ€์ƒ‰ํ•˜๊ณ , ํ•„์ˆ˜ ์•ฝ๊ด€ ๋™์˜๋ฅผ ๊ฒ€์ฆํ•œ ํ›„, ์‚ฌ์šฉ์ž์™€ ํ•จ๊ป˜ ์•ฝ๊ด€ ๋™์˜ ๊ด€๊ณ„๋ฅผ ์ €์žฅํ•˜๋„๋ก ์ˆ˜์ •๋ฉ๋‹ˆ๋‹ค. ์ถ”๊ฐ€๋กœ ํ…Œ์ŠคํŠธ์šฉ ๋กœ๊ทธ์ธ ์—”๋“œํฌ์ธํŠธ์™€ AuthTestService๊ฐ€ ๋„์ž…๋˜๋ฉฐ, ์•ฝ๊ด€ ์‹œ๋“œ ๋ฐ์ดํ„ฐ๋ฅผ ์œ„ํ•œ SQL ํŒŒ์ผ๊ณผ ์ƒˆ๋กœ์šด ์—๋Ÿฌ ์ฝ”๋“œ๊ฐ€ ์ถ”๊ฐ€๋ฉ๋‹ˆ๋‹ค.

Sequence Diagram

sequenceDiagram
    participant Client
    participant AuthService
    participant TermRepository
    participant UserRepository
    participant Database as DB

    Client->>AuthService: googleSignup(request: GoogleAndAppleSignupRequest)
    Note over AuthService: request contains agreedTerms: List<String>
    
    AuthService->>TermRepository: findAllByTitle(agreedTerms)
    TermRepository->>Database: SELECT t FROM Term WHERE t.title IN (...)
    Database-->>TermRepository: List<Term>
    TermRepository-->>AuthService: terms

    rect rgb(200, 220, 255)
        Note over AuthService: Validation Phase
        AuthService->>AuthService: Verify count matches
        AuthService->>AuthService: Enforce required terms
    end

    AuthService->>AuthService: Create UserTermAgreement<br/>for each term

    AuthService->>UserRepository: save(user with agreements)
    UserRepository->>Database: INSERT user + agreements
    Database-->>UserRepository: success
    UserRepository-->>AuthService: saved user

    AuthService-->>Client: signup result
Loading

Possibly related PRs

  • Feature/35 termย #38: ๋™์ผํ•œ ์ฝ”๋“œ ๋ ˆ๋ฒจ ๋ณ€๊ฒฝโ€”GoogleAndAppleSignupRequest์— agreedTerms ์ถ”๊ฐ€, Term ๋ฐ UserTermAgreement ์—”ํ‹ฐํ‹ฐ ๋„์ž…, AuthService ๊ฐ€์ž… ๋กœ์ง์˜ ์•ฝ๊ด€ ๋™์˜ ์ฒ˜๋ฆฌ.

  • feat : google login ๊ตฌํ˜„ ์™„๋ฃŒ (ios ๊ตฌํ˜„ ์ค‘)ย #30: GoogleAndAppleSignupRequest ๋ฐ AuthService ์ธ์ฆ ํ๋ฆ„ ํด๋ž˜์Šค ์ˆ˜์ •โ€”์ด์ „ Google/Apple ๊ฐ€์ž… ์ž‘์—… ์œ„์— ์•ฝ๊ด€ ์ฒ˜๋ฆฌ ๋กœ์ง ์ถ”๊ฐ€.

  • Deploy: Merge to mainย #33: AuthService ๋ฐ GoogleAndAppleSignupRequest DTO ์ˆ˜์ •โ€”๊ฐ€์ž… ํ๋ฆ„์˜ ์•ฝ๊ด€ ๊ด€๋ จ ์ฝ”๋“œ ๋ ˆ๋ฒจ ๋ณ€๊ฒฝ.

โœจ Finishing touches
  • ๐Ÿ“ Generate docstrings
๐Ÿงช Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

๐Ÿ“œ Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 22950d4 and bbb080f.

๐Ÿ“’ Files selected for processing (14)
  • .github/workflows/ci-cd.yml
  • src/main/java/ita/tinybite/domain/auth/dto/request/GoogleAndAppleSignupRequest.java
  • src/main/java/ita/tinybite/domain/auth/repository/TermRepository.java
  • src/main/java/ita/tinybite/domain/auth/service/AuthService.java
  • src/main/java/ita/tinybite/domain/user/entity/Term.java
  • src/main/java/ita/tinybite/domain/user/entity/TermCode.java
  • src/main/java/ita/tinybite/domain/user/entity/User.java
  • src/main/java/ita/tinybite/domain/user/entity/UserTermAgreement.java
  • src/main/java/ita/tinybite/global/exception/errorcode/AuthErrorCode.java
  • src/main/java/ita/tinybite/global/health/LoginReqDto.java
  • src/main/java/ita/tinybite/global/health/controller/HealthCheckController.java
  • src/main/java/ita/tinybite/global/health/service/AuthTestService.java
  • src/main/resources/application-local.yaml
  • src/main/resources/term/terms.sql

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yyytir777 yyytir777 merged commit ee52faf into main Dec 24, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants