-
Notifications
You must be signed in to change notification settings - Fork 0
Deploy: Merge to main #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Feature/13 user
* feat : google login ๊ตฌํ ์๋ฃ (ios ๊ตฌํ ์ค)
* feat : google login ๊ตฌํ ์๋ฃ * fix : user hard delete * feat : apple ๋ก๊ทธ์ธ ๊ตฌํ ๋ฐ ddl-auto -> update ๋ณ๊ฒฝ
* ์ฝ๊ด ์ํฐํฐ ์์ฑ ๋ฐ ์ฐ๊ด๊ด๊ณ ์ค์ * ํ์๊ฐ์ ์ ์ฝ๊ด ์ ์ฅ ๋ก์ง ์ถ๊ฐ * ์๋ฒ์์ idToken์ ๋ฐ์์ฌ ์ ์์ผ๋ฏ๋ก ๋จ์ํ ์ด๋ฉ์ผ๋ก accessToken์ ๋ฐ์์ค๋ test API ์ถ๊ฐ
|
Caution Review failedThe pull request is closed. ๐ WalkthroughWalkthrough์ด ํ ์์ฒญ์ Google ๋ฐ Apple ๊ฐ์ ํ๋ฆ์ ์ฝ๊ด(Term) ๋์ ๊ธฐ๋ฅ์ ์ถ๊ฐํฉ๋๋ค. ์์ฒญ DTO์ ๋์ํ ์ฝ๊ด ๋ชฉ๋ก ํ๋๋ฅผ ์ถ๊ฐํ๊ณ , ์๋ก์ด Term ๋ฐ UserTermAgreement ์ํฐํฐ๋ฅผ ๋์ ํ์ฌ ์ฌ์ฉ์-์ฝ๊ด ๋งคํ์ ๊ด๋ฆฌํฉ๋๋ค. AuthService์ googleSignup ๋ฉ์๋๋ ์ ๊ณต๋ ์ฝ๊ด์ ๋ฐ์ดํฐ๋ฒ ์ด์ค์์ ๊ฒ์ํ๊ณ , ํ์ ์ฝ๊ด ๋์๋ฅผ ๊ฒ์ฆํ ํ, ์ฌ์ฉ์์ ํจ๊ป ์ฝ๊ด ๋์ ๊ด๊ณ๋ฅผ ์ ์ฅํ๋๋ก ์์ ๋ฉ๋๋ค. ์ถ๊ฐ๋ก ํ ์คํธ์ฉ ๋ก๊ทธ์ธ ์๋ํฌ์ธํธ์ AuthTestService๊ฐ ๋์ ๋๋ฉฐ, ์ฝ๊ด ์๋ ๋ฐ์ดํฐ๋ฅผ ์ํ SQL ํ์ผ๊ณผ ์๋ก์ด ์๋ฌ ์ฝ๋๊ฐ ์ถ๊ฐ๋ฉ๋๋ค. Sequence DiagramsequenceDiagram
participant Client
participant AuthService
participant TermRepository
participant UserRepository
participant Database as DB
Client->>AuthService: googleSignup(request: GoogleAndAppleSignupRequest)
Note over AuthService: request contains agreedTerms: List<String>
AuthService->>TermRepository: findAllByTitle(agreedTerms)
TermRepository->>Database: SELECT t FROM Term WHERE t.title IN (...)
Database-->>TermRepository: List<Term>
TermRepository-->>AuthService: terms
rect rgb(200, 220, 255)
Note over AuthService: Validation Phase
AuthService->>AuthService: Verify count matches
AuthService->>AuthService: Enforce required terms
end
AuthService->>AuthService: Create UserTermAgreement<br/>for each term
AuthService->>UserRepository: save(user with agreements)
UserRepository->>Database: INSERT user + agreements
Database-->>UserRepository: success
UserRepository-->>AuthService: saved user
AuthService-->>Client: signup result
Possibly related PRs
โจ Finishing touches
๐งช Generate unit tests (beta)
๐ Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ๐ Files selected for processing (14)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
๐ ์์ธ ๋ด์ฉ
Summary by CodeRabbit
๋ฆด๋ฆฌ์ค ๋ ธํธ
์๋ก์ด ๊ธฐ๋ฅ
Chores
โ๏ธ Tip: You can customize this high-level summary in your review settings.