Skip to content

Conversation

@havardAasen
Copy link

Copy of the longest commit messages:

ClassicLadder: Update the configuration

This also moves the RT target from 'hal/components/CMakeLists.txt'.
Easier to handle the source files when they are in the same place.
Several of the compiler definitions that was only useful to
ClassicLadder has been moved to this CMakeList, less pollution for
all the other targets that's being built.

The source code has also moved to GTK3.

Not sure if you agree with this one, but I believe that having the configuration located in the same file makes things a lot easier.


Compile linklist with fPIC
Needed since it is used in other libraries with PIC.

Should this really be a separate library? it wasn't that before. To me this almost invites other people to include it in their projects. which I believe should be avoided.


Add function to build Python binaries

There is one TODO in this file, we use 'sed' to update the shebang line,
I'm not sure if this is needed. Looking at the Git history, it's been
around for over 15 years.

With GNU Autoconf the shebang lines will have both the major and minor
Python version:

#!/usr/bin/python3.11

With the current command in CMake:

#!/usr/bin/python3

This also moves the RT target from 'hal/components/CMakeLists.txt'.
Easier to handle the source files when they are in the same place.
Several of the compiler definitions that was only useful to
ClassicLadder has been moved to this CMakeList, less pollution for
all the other targets that's being built.

The source code has also moved to GTK3.
@ev1313
Copy link
Collaborator

ev1313 commented Jan 18, 2024

Hello,

the Python sed should not be necessary in 2024, the shebang probably should be replaced in all relevant files with "/usr/bin/env python3" as this automatically uses the default installed python3 version.

The other changes I will review and probably merge.

There is one TODO in this file, we use 'sed' to update the shebang line,
I'm not sure if this is needed. Looking at the Git history, it's been
around for over 15 years.

With GNU Autoconf the shebang lines will have both the major and minor
Python version:
    #!/usr/bin/python3.11

With the current command in CMake:
    #!/usr/bin/python3
Needed since it is used in  other libraries with PIC.
@havardAasen
Copy link
Author

the Python sed should not be necessary in 2024, the shebang probably should be replaced in all relevant files with "/usr/bin/env python3" as this automatically uses the default installed python3 version.

I actually think most Python files has that shebang line already, this might have been a relic that has been copy-pasted in the build system.

The sed command has been removed. Let me know if there is something more I should change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants