Create HAL userspace components and generate man pages #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also moves the RT target from 'hal/components/CMakeLists.txt'. Easier to handle the source files when they are in the same place. Several of the compiler definitions that was only useful to ClassicLadder has been moved to this CMakeList, less pollution for all the other targets that's being built. The source code has also moved to GTK3.
There is one TODO in this file, we use 'sed' to update the shebang line,
I'm not sure if this is needed. Looking at the Git history, it's been
around for over 15 years.
With GNU Autoconf the shebang lines will have both the major and minor
Python version:
#!/usr/bin/python3.11
With the current command in CMake:
#!/usr/bin/python3
Needed since it is used in other libraries with PIC.
Collaborator
|
Hello, as in #5 we need to add another parameter to compile_component, I will first add a parameter there and afterwards rebase onto these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #3
This updates
compile_component()to accept another parameter, specifying if it is a userspace or rt component.The next commit also add the possibility to create man pages in the same function. This could have been split out into a separate component but since we already used halcompile it seemed like a nice place for it.