Open
Conversation
niyazmnazari
left a comment
niyazmnazari
left a comment
There was a problem hiding this comment.
Thank you for submitting assignment 1. Everything looks correct.
Point: 30/30
Owner
Author
|
Hello Niaz,
Thanks for the feedback!
Should I close the pull request?
…On Mon, Dec 16, 2024 at 12:35 Niyaz Nazari ***@***.***> wrote:
***@***.**** commented on this pull request.
Thank you for submitting assignment 1. Everything looks correct.
Point: 30/30
—
Reply to this email directly, view it on GitHub
<#1 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BM4AX6PHC7WH4JNEYMFASET2F4FM3AVCNFSM6AAAAABTU37JLGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMBWHA2TSNBXG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
niyazmnazari
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding code
What did you learn from the changes you have made?
using functions to analysis database
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
it was an standard approach
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
none
How were these changes tested?
good
A reference to a related issue in your repository (if applicable)
Checklist