This repository was archived by the owner on Jan 14, 2024. It is now read-only.
Glasgow class 6- Yesna Omar- html/css- week 1 #288
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,3 +6,55 @@ | |
| * for example: General styles, Navigation styles, Hero styles, Footer etc. | ||
| * | ||
| */ | ||
| body { | ||
| background-color: rgb(227, 237, 241); | ||
| margin: 2em; | ||
| padding: 1rem; | ||
| display: flex; | ||
| flex-direction: column; | ||
| } | ||
|
|
||
| h1{ | ||
| color: black; | ||
| text-align: center; | ||
| } | ||
| nav{ | ||
| text-align: center; | ||
| margin: 4rem; | ||
| } | ||
| main{ | ||
| margin: 3em; | ||
| padding: 1em; | ||
| padding-left: 23em; | ||
|
Member
There was a problem hiding this comment. It's rarely wise to use padding to position things. And even more risky to use em sizing. Try zooming your browser to 200% to find out why! 😉 https://www.boia.org/blog/give-yourself-an-accessibility-test-zoom-your-page-to-200 |
||
| display: flex; | ||
| flex-direction: column; | ||
| } | ||
| p:first-child { | ||
| margin: auto; | ||
| } | ||
| aside{ | ||
| margin:1em; | ||
| padding-top: 1em; | ||
| padding-left: 5em; | ||
| display: flex; | ||
| flex-direction: column; | ||
| } | ||
| .column{ | ||
| float: left; | ||
| width: 50%; | ||
| } | ||
| .row{ | ||
| content: none; | ||
| display: table; | ||
| clear: both; | ||
| } | ||
| img{ | ||
| width: 15em; | ||
|
|
||
| } | ||
| footer{ | ||
| margin: 2em; | ||
|
Member
There was a problem hiding this comment. What would happen if you set the font size on the footer to 2em? Try it and have a think about when em sizing is a a good idea vs rem sizing (or other CSS units) |
||
| padding: 1rem; | ||
| padding-left: 23em; | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to set the heading colour to black? What would happen if you removed this rule?