This repository was archived by the owner on Jan 14, 2024. It is now read-only.
Glasgow class 6- Yesna Omar- html/css- week 1#288
Open
Yesna-Omar wants to merge 2 commits intoCodeYourFuture:masterfrom
Open
Glasgow class 6- Yesna Omar- html/css- week 1#288Yesna-Omar wants to merge 2 commits intoCodeYourFuture:masterfrom
Yesna-Omar wants to merge 2 commits intoCodeYourFuture:masterfrom
Conversation
Member
SallyMcGrath
left a comment
SallyMcGrath
left a comment
There was a problem hiding this comment.
Lovely work, @Yesna-Omar ! I can see you've put a lot of effort into your design. I've asked a few questions you might find useful to think about. Thanks so much for this!
| main{ | ||
| margin: 3em; | ||
| padding: 1em; | ||
| padding-left: 23em; |
Member
There was a problem hiding this comment.
It's rarely wise to use padding to position things. And even more risky to use em sizing. Try zooming your browser to 200% to find out why! 😉
https://www.boia.org/blog/give-yourself-an-accessibility-test-zoom-your-page-to-200
| } | ||
|
|
||
| h1{ | ||
| color: black; |
Member
There was a problem hiding this comment.
Is it necessary to set the heading colour to black? What would happen if you removed this rule?
|
|
||
| } | ||
| footer{ | ||
| margin: 2em; |
Member
There was a problem hiding this comment.
What would happen if you set the font size on the footer to 2em? Try it and have a think about when em sizing is a a good idea vs rem sizing (or other CSS units)
| <aside> | ||
| <img src="data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/2wCEAAoHCBYWFRgRFRIYGBgYEREYGBgYGBIYGBgYGBgZGRgYGBgcIS4lHB4rIRgYJjgmKy8xNTU1GiQ7QDs0Py40NTEBDAwMEA8QGhISHjQhISE0NDQ0NDQ0NDQ0NDQ0NDE0NDQ0NDQ0NDQ0NDQ0NDQ0NDQ0NDQ0NDQ0NDQ0NDQ1ND80NP/AABEIAOEA4QMBIgACEQEDEQH/xAAbAAACAgMBAAAAAAAAAAAAAAAAAgEDBAUHBv/EAEQQAAIBAgEGCQcKBgMBAQAAAAABAgMREgQFITFRYQYTQVNxkaKy0RQVFySBgqEHIjI0QnN0sbPBM1KDkuHwI2JyZBb/xAAZAQADAQEBAAAAAAAAAAAAAAAAAQIDBAX/xAArEQACAgIBBAECBgMBAAAAAAAAAQIRAxIxBBMhQVEygTNhcZGh0RRCsSL/2gAMAwEAAhEDEQA/AOytiOYVGeK4U8KZ5NVjSjTjJOlGd5Yr3cpxtof/AFAcYuTpHtOMDGcx9INXmYdcvElfKBV5mn2vEC+1I6bjDGcz9IFTmYdrxJXD+pzMO14isO1I6XjDGc0fD+pzMO14kf8A7+rzMO34hY+zI6ZjDGcy9INXmYdrxD0gVeZh2/Edi7UjpuMMZzH0hVeZh2/Ej0g1eZp9vxAXbkdPxhjOYekGrzMO34h6QqvM0+34gHbkdP4wOMOYekOrzNPt+JHpCq8zT7fiAaM6hxgcYcv9IVXmafb8Q9IVXmafb8QoO3I6hxgcYcu9IVXmafb8Q9IVXmafb8QoO3I6jxgcYctfyhVeZp9vxI9IVXmafb8QoWjOpcYHGbzlvpCq8zT7fiK/lDq8zDt+IBozqnGbw4zecq9IVXmYdvxI9Idbmafb8QHozq6qbx1I5tmHhrUr14UZU4RU8d2sV1hhKS1vce+yatcCWmuTNAAARVUOVfKO/WYfhofqVDqtU5R8pP1mH4aHfqiZrh+s8rci5WmMCOhj3GTEQyAExiACwhkASFhiIIsNYLAIWwrRYQ0MViWCw5FgBC2Iwj2JSAdCYRWi0VgFCNED2CwWKhLEWLMIOAtkVoUtEWLcAOIth6UbTgjoyul/U/TmdgzdI5BwW+tU/wCp3JnXM1saObN9RuQABmRVUOT/AClP1mH4aHfqHWKhyb5TPrMPw0P1Kgma4frPJNkKRXiHSuTZ1VZZGRYilRHiyhUWBYGCkFiomxNhdIyYBQpNiRrDFQliLD2IwhZIpNhrBYBiYRrD2IaEUI0K0WWIwgAliVAawCGqFcRWPIRoSQ2/ghkMkGUTZsuDC9Zp+/3JnW8znJODX1mn7/ckdazMM58v1G7AAAyKqhyj5S/rUPw0P1Kp1eoco+UpetQ/DQ/UqEz4N+nV5F9/+HjHEdDWGjEy2PQeMVSGQygNGA9hdoGgUSyw8YC3L7YkUTgLMBGEexDgxMJFh2hbFpmMosEibDJAOydRbEpDWBhYaisiwyALCiBWhrE2CwpiWIsWWFsFhQjiK0WNCjE0I0K0OyGgFwZ/Bz6zD3+5I61mU5Nwd+sw9/uSOs5kGc+Tk3YAAGZVUOY/KDSvlEH/APPD9SodOqHOeHMb14/cQ79QyzfSdfRfjfZnkPJgjk5nwpjqBxbNHuapmDGgO6JmqwrSHbE0jD4klQMvCRhQ7FSMbAJKBm4EUziNSE4ow5wK7GXKIsqN9RqpfJzzx/BjtkYi10BXTNFJGMoSQjkRiHdMjCVaIcWRiC5KgGELDVkORGIloVoAolzI4wWwrGQO5BcqIxFIzZa2KxFIm5SM22bLg8vWYf1O5I6zmTUcm4O/WIe/3JHWcyAzKfJuwABEFVU53w3X/PH7mPfmdDqHPuG38eP3Ee/UMs30HX0X4v2Z5y5OIaMbk4DktHs+SmUWQjIwg6YbC1KMQrkXumVuI0DFg94Sgx4oZzB36H4KpUyIuw8ncrkgSvkTdcCVZFLZc4MjCaKqMXbZUmMh8JFhgiAsTcjEFBaEcRZRHbEkPyS6K5REkh5FbKVkOhJIrZa0LhGmQ4oruCZZgJwj2J7dmfwc+sQ9/uyOt5kOT8H16xD3+7I6xmQuLtHH1EdZL9DdgAFGBTVPA8M43rx+5j35nvqp4DhrUtXj9zHvzMsyuJ1dG6y/ZmgUSWhIVkWOa1nI1R7KlfDEZAcagckOhbCuoRGohJtCFKJPcL3JCORWDbFqG46HjTuVRe4yKbewT8FR8g4COBkK7K6kWQmaNfBQ4CuA7k+UWVU0MrXsSVMrcCx1UQ5DVidPgoaIlEvElErYnUoaKZIynEWUClIhwTMUEi6UBcI9idBbANhFaFZWtGw4P/WIe/3ZHV8yajlHB9esQ9/uyOr5k1G2Pg87q/rX6f2bsAAs5Sqqc74cRvXj9zHvzOh1TwnC+i5Votc1HvzJlwa4XUzyXF8o1mZvFNa0RGG4Wh0vM17MLi9ws6bRsHTewXBtKUEQ80jW4QszNq07akU3tyCcRrKU4WCTLrrlGutSJ0+Sll+GVK6H4xjRI5bCeNGkc0vTI8oYkspe8eUSmUlyiWJFPqZLkl5WY8q5M3EpmtjKWJIzfUt+x3XGjWMW+0jRtHpYlmZncYRiMNX2jKRDxmqz2ZNyWjHxkqZOhosyLJMW43GJqzRUwURvIvQzYrkGEMIaB3TYZhfrEPf7sjqmZNRyvMMfWIe/3ZHVMyajWCpHn9VLaaf5f2bsAAs5iqqeL4Ufxo/cx70j2lU8VwonatFWv/wx70yMn0m/TfiL7mrw6bg6C12GTQ19lzOE6R15MSk7KZ0X0mFWjbQbJbGYlRWldvR1lLIzN4o15MPHuFm0ZqlDp9g9SnB6W0DyP4GsEK+o18Yxa0CSoJajKagno/YG19mz/wB3lxcmuDKei8JmG6W8Ti3yF81N8lhXiStbqRTsiLjfJWm1oYsugyI1eRwVwnF7EZO74OtNVzZr500UOGnQZ8oPYI6e4tNmElH0Y0KG0WeTIzLiuI1YnpXhGEqaREkZEoCYSjMoS3go7y/ixZRQDspuyE947iVyjuFQbMlytyk4ypi8Yx6oNzc8H5esQ9/uSOq5k1HI+DlVvKYL7zuSOuZk1CqjObtm7AAAgqqnkeEU48ZFO13TWl7MUj11U8Xwm/ix+7XekGu3gayOD2RhLir6308hZChGS+bKxgR0chdkkYt67PZqM54qV2zpxdTtJKl/witklrtts1dem9NrnpuJ5Ul1lLyda8CZzvK0d0cUXyeZpZNN6ossdBrQ0beo3F6FbcimeVwX0o/C6E8uS/CsOxhryzR1ISRjOpM9DPKqbT02dtVn8DC8qgvsfsXHNkf+pEsGFf7GHSyya13sXeWvYXwipfZIqZMk9hpHJ5pmc8Pi4u0JGrdBKpuMvJqC1N6DMjk8NbaYSyNcImGOEuWaVTuWRoX1Gzm6MdTTd9Wgxamc4x+jBW9jHGc36FPHjjzIoWSNiToOI88vUvs9VymplTej8zSn7MlKKXgVx2opnTRE6gRdwpIW7l6KpwRXdbB6k7GPKoNeSG6GnNbCmUtg7qdPUFr8g7oEm34KJCWeozFBcqFwJO6J7i9GnYfsyODsGsphdc53JHXcyajleYp+sQ9/uyOqZk1DuzLJFRdLybsAADMpqni+E8b14LRfi1r/APUz2lU8Rwq/jR+6js/mkNCboxamR6NGvdcpWSO9r/t+ZEcomrPE+tF9SqpLTr6DNbo6G8MuF5/axqdCUNXXe5bFTels18YO/wA1uPRJmdCE4r6akuv8wnGQYskPSar8xYz0219KQ1bNilp0ewipUeq1hKKmnob62ZvFJq06NV1MIvXkxZZl0hPM9tSMqpCT+k2/ayiVDZJk9ufyad/H6iRDI7bC50G/sGNPJuXFp9pXSg1LTJ+y4PFJ+bH/AJUE6r+Sa9Ga5EjAyilK2n4f4Nu8otqWLpJjlGL7Fuh/mUu6vREngk+TzE6Mm7a+nQZdLJLprS/YvzNrlNLZ+xjRUlv3DbnJfAowxwlxZgum1otZGFWve9jdZXHFFvA720Hn5ZFWm/m05P2MnHN+bpG2bEqWqbsh1uS4195XLN1Va4MshkVR6FE12i/aObtyT8piNcqQrk0ZdLIqj0NXLHm6X2uoW6L7UuTXKqNj6TM8kewVZK9g/BO0kYznfQ7lU7bzYxyZ8pj1aVtFhL4Q5TdXIv4PL1iD/wDfckdZzIcvzI1x8LRtolf+yR1DMmotHPkab8OzdgADMymseT4QZM51FK1/mJdqXierrGnypfO9g0TLg8qsi06mi7yH/t7GjfNC4RshUvRo5ZI1y/mTClLbY3TgiOLWwBGnlRf+suhT0aGk+lWNhKnHYVOjHYDVjjKmY3FSas7X6b3KIUmtcfaZ/FRErzSWu3suZyVI3xtTaTdfya+tDTYp4ncTlFRSvhm0+gxJV60NLtNdCv1kxzx4fg1ydJkfmP8A6RnRyfXdIrjQS5DHp59V7ShKN/z2l88rjbFZ9Ohpg8qTp+xx6aTjaXH8DVKmxddiMctDw2V9aV77iI1YS0p/Esp042+nr5G/8iqHwCllT8vwUSy9p6ad18RHlqxanbkMh04csl1kQpx5JX6LFLFj9Ih9TlXLsxpZXF60/wDekillUVf5rd3u1GZxP8sU+kupZK3yL4B28flA8+bw/wBjVcZhldTbTWhWt1jvKG1pj8DZyye3IvgVVa8EmtXSTOMP1NMWTJbT8GolNN/R09LKZ1VyfkU5xzhhbw6eqxqXnOb1/BJCSvlG0pNeE/L/ACNpVnvMWrUXK+tmFUrS2vrMedRcprHVcHNOOR8s3uZKl8ogvvO5I6jmQ5BwZrXymEfvO5M6/mTkGzGqN4AAAGPlDNXW1mzyjUzWMCZcFWEjCXYQwjsiilxIcC6xGELCih0yHSL5WWl6DGllcb4b6er8wsVEOj0CSyW48671KPWXRvy2B+Sk2uDCebo7F7Qjm6NrN3V9VjNsThMpYYS5OiPVZI8M1ss1U3yP2pFTzPC1lLRsNq0Q4kf42P8AP9y112Ze7NDU4Or7E7e0ahmNr6TTWxm7cRHEawriwfWy+KMCnminHRxa+NyY5vhDTFW6jMcCGiliS9kS6qTVUjD4prU2TThZ6WzJcBXA0as54zcWq9GJWg+Q0ecKc3f5jfRc9I4FVSndWM3iT5OmPVyXCo5/lVLWnAwJRa5D3lfNkZbvZ/kxp5hT1z+BShQS6nZ2eGlJ7DFqM93lPB2LTwNL2M02U8GKnI0y0qM3mvk1/BSXrdNX5z9OZ2nMnIcjzBmqdPKYSlBpLjLvk0wkv3Ot5jBoV2b0AAQGPlWpmleUJa9pvqsLqxp8oyDToQAUeVw39QeWw2vqGWbnsJWbHsAnVFfl0Nr6mK8thtfUzJWa3sGWatwBqjDllcHobfUxfKYb/wC3/BnrNW4ZZq3AGqMCOVQ2vqZPlkN/UzP81k+awDVGv8rhv6mR5ZDf1M2XmtB5rQBqjWeVw39TDyqO/qZtPNaDzWgDVGqeUx39TFeUx39TNv5rQea0Aao03lMdj6iHlEdj6jc+a0HmtAGqNI8oWx9RDrrY+o3fmsjzUAao0brrYxJVlsfwN95q3EPNW4LDVHnZ1nyQb/t8SiVaf8j64eJ6h5q3CPNW4A1R5nHPli+uPiK5S/kfXDxPTPNO4R5o3AGqPORk76YW33j+zPT5i1IoeaP+psM25K4PVoAaVG1AAAYAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAB//9k=" alt=""> | ||
| <br/><br/> | ||
| <img src="https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcRGwbAdRZVvkj6LdTQvjFJa-4j-M22BuZ0xcw&usqp=CAU" alt=""> |
Member
There was a problem hiding this comment.
How might describe these images in an alt tag? Why is this valuable to do?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your Details
Homework Details