Support multiple view types. #91
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luongvo
reviewed
Mar 20, 2018
| container.setDraggable(false); | ||
| ViewGroup parent = container.getContentContainer(); | ||
| View child = adapter.getView(lastIndex, parent.getChildAt(0), parent); | ||
| if (parent.getChildCount() != 0 && !parent.getChildAt(0).getTag().equals(child.getTag())) { |
There was a problem hiding this comment.
what happen if the tag is null? or empty for the both
Author
There was a problem hiding this comment.
true, I was assuming the recommended design but its not mandatory.
Gonna fix that.
Closed
Owner
|
@stumi01 @luongvo Sorry, ver. 2.0.0 is fully re-implemented by RecyclerView, so it's difficult to merge your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered a problem ,
when you have multiple view types defined in the adapter with multiple view holders.
If the view got recycled but the new child is a different type it's got ignored.
In the fix I compare the existing child with the new one and if the viewHolder is different i drop the previous child.