feat(quality): add skill completeness checks #207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds completeness checks to
quality_checker.py, addressing G2.3 and G2.4 from the roadmap.What's Included
New
_check_skill_completeness()method that validates:Prerequisites/Verification Sections
prerequisites,requirements,before you start,verify thatError Handling/Troubleshooting Guidance
troubleshooting,common issues,if ... failsWorkflow Steps
step 1,first,then,next,finallyDesign Decisions
Roadmap Alignment
Tests Included
4 new unit tests in
TestCompletenessChecks:test_checker_detects_prerequisites_sectiontest_checker_detects_troubleshooting_sectiontest_checker_detects_workflow_stepstest_checker_suggests_adding_prerequisitesExample Output (verbose mode)
Code Style
Follows existing patterns:
_check_*method naming conventionreport.add_info()call patternThis PR builds on the Best Practices Guide (#206) - the patterns checked here match what that guide recommends.
Contributed by the AI Writing Guide project.