Return early in yaml_emitter_close #292
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
CI failure addressed by #293 |
perlpunk
force-pushed
the
check-emitter-error
branch
2 times, most recently
from
e584022 to
635a691
Compare
If yaml_emitter_dump failed, the emitter might be in a broken state and have leftover states/events. yaml_emitter_close calls yaml_emitter_emit which will try to emit those events, so we should return early. The recommended thing to do for library users is to abort when yaml_emitter_dump fails, but it's easy to add a check here as well.
perlpunk
force-pushed
the
check-emitter-error
branch
from
635a691 to
3a0d3a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
yaml_emitter_dumpfailed, the emitter might be in a broken state and have leftover states/events.yaml_emitter_closecallsyaml_emitter_emitwhich will try to emit those events, so we should return early.The recommended thing to do for library users is to abort when
yaml_emitter_dumpfails, but it's easy to add a check here as well.