Skip to content

Add os import in setup.py #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pavellippov wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add os import in setup.py #1

pavellippov wants to merge 5 commits into from

Conversation

@pavellippov
Copy link

@pavellippov pavellippov commented Feb 22, 2023

Without it pip install . fails with the `

  File "/tmp/pip-req-build-iqr76ooo/setup.py", line 79, in <module>
        os.environ.get('MSGPACKRPC_TORNADO_EXTENSION') != '0'):
    NameError: name 'os' is not defined

Tested on

Ubuntu 18.04.4 LTS 
python 3.8.2
pip 19.2.3

xaedes and others added 5 commits February 18, 2022 03:21
@xaedes
Add tornado 4.5.3 from https://github.com/tornadoweb/tornado/tree/v4.5.3
5ad5432
@xaedes
Change msgpackrpc code to use own copy of tornado with specific versi…
d7bc9db 
…on 4.5.3
@xaedes
Change tornado code imports to use msgpackrpc/tornado
3c40769
@xaedes
Add necessary code from tornado 4.5.3 to setup.py
4a308d3
@pavellippov
Import os in setup.py
012b99b 
Without it `pip install .` fails with the `
```
  File "/tmp/pip-req-build-iqr76ooo/setup.py", line 79, in <module>
        os.environ.get('MSGPACKRPC_TORNADO_EXTENSION') != '0'):
    NameError: name 'os' is not defined
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pavellippov @xaedes