Fixed CERT_REQUIRED Not Requiring Client Verification
#61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where Python's
CERT_REQUIREDmapped only toWOLFSSL_VERIFY_PEERinstead of also includingWOLFSSL_VERIFY_FAIL_IF_NO_PEER_CERT.As a result, setting
verify_mode = wolfssl.CERT_REQUIREDcausedwolfSSL_CTX_set_verifyto be called with justWOLFSSL_VERIFY_PEERflag, making the WolfSSL server request a client certificate but still accept the connection when none was provided.Added
CERT_OPTIONALwhich now takes the previous value ofCERT_REQUIREDand provides the correctly functionality.This variable was mentioned multiple times (in
wrap_socketand inverify_mode's getter and setter).