Add support for UNIX domain socket#255
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
===========================================
- Coverage 85.21% 59.69% -25.53%
===========================================
Files 6 12 +6
Lines 717 1228 +511
===========================================
+ Hits 611 733 +122
- Misses 76 463 +387
- Partials 30 32 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@googlebot I signed it! |
Allows listening to Unix domain socket with the `-addr` option. The syntax is `unix:path`. (same as nginx `listen` directive)
|
thanks for this. I reworked it a tad, since things have changed a bit since you opened this, but looks good. |
This PR adds UNIX domain socket support for the addr option.
I want this as I run all my services behind nginx with unix domain socket.
I suppose there are more reasons someone would want to run
imageproxy without listening to a TCP port.
I never wrote any Go before this PR, I hope I haven't done anything stupid...