Open
Conversation
Please note that this modification is not deeply tested. It was done to solve a SINGLE incorrect behavior, so I don't know if it will still behave normally in other situation. The problem was that if SVN is not installed/found, `callback` was called on `ChildProcess#error` but also when the process run normally `ChildProcess#close`. Now callback is run only when process leave stdio. I repeat that this is absolutelly not tested in every case, but it seems coherent. Also, can you update NPM package to integrate my previous changes & generate documentation? Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note that this modification is not deeply tested. It was done to solve a SINGLE incorrect behavior, so I don't know if it will still behave normally in other situation.
The problem was that if SVN is not installed/found,
callbackwas called onChildProcess#errorbut also when the process run normallyChildProcess#close. Now callback is run only when process leave stdio.I repeat that this is absolutelly not tested in every case, but it seems coherent.
Also, can you update NPM package to integrate my previous changes & generate documentation?
Thanks