Add ToPlaceholders TermTransformer#806
Merged
quickbeam123 merged 6 commits intomasterfrom Jan 27, 2026
Merged
Conversation
…eholder constant # Conflicts: # Kernel/HOL/Create.cpp # Kernel/HOL/HOL.hpp
mezpusz
reviewed
Jan 24, 2026
mezpusz
reviewed
Jan 24, 2026
mezpusz
reviewed
Jan 24, 2026
mezpusz
reviewed
Jan 24, 2026
hetzenmat
force-pushed
the
matthias-to-placeholders
branch
from
bdf11ee to
8b40883
Compare
mezpusz
approved these changes
Jan 26, 2026
Contributor
Author
|
Thank you. |
quickbeam123
approved these changes
Jan 27, 2026
Collaborator
|
Good job, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ToPlaceholdersterm transformer allows to replace higher-order subterms by a special polymorphic placeholder constant.This is a preparation for the HOL unification machinery, as we can then use a
SubstitutionTreeas a filter for the first-order term skeletons before we even start with the expensive HOL unification.Also, I renamed the HOL unit tests in order to be able to run them all with the command
ctest -R HOL_.