FlowLink parameter: Allow tapGesture activation for FlowLink navigation #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zac
requested changes
Nov 12, 2025
Sources/FlowStack/FlowLink.swift
Outdated
| private var button: some View { | ||
| switch activation { | ||
| case .overlayButton: | ||
| return AnyView( |
Member
There was a problem hiding this comment.
☝️ Please avoid AnyView as it can have pretty bad performance effects. Should be able to use a Group without issue here.
zac
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
NOTE: the change is simple enough to allow for the functionality, but trying to mimic the “press feedback” (scale shrink) effect would require a bigger effort and changes. Something on the lines of, providing a way to manually indicate interactive regions to FlowStack, so the whole view doesn't scale when tapping on those.