Skip to content

Conversation

@Strift
Copy link

@Strift Strift commented Jul 26, 2017

This should fix the issue #557

Sorry this is WIP. I will update when I'm done.

@Strift Strift changed the title Fix error where app name would be used instead of command help name WIP: Fix error where app name would be used instead of command help name Jul 26, 2017
@Strift
Copy link
Author

Strift commented Jul 26, 2017

I know there are failed assertions when running this fork. But I have no idea why are the tests failing.

@jszwedko If you could tell me what I should do to make the tests pass / refactor the tests, I would gladly investigate a bit more.

@jszwedko
Copy link
Contributor

jszwedko commented Aug 9, 2017

Hi @Strift,

Thanks for taking a crack at this! Apologies for the delay, just getting back from traveling.

I believe this change does break behavior that was introduced in #267 (see that thread for more discussion) which is why you see the failing tests here.

I think there are more nuances described in #557 than what you are describing here though. I think to address that issue a more drastic overhaul of the help system will be required to handle all of the cases described there. I think it can be simplified along the way though.

@coilysiren
Copy link
Member

Given that this PR is from years ago, I think I'm comfortable closing it 🙂 feel free to re-open / open a new PR if there's still interest here!

@coilysiren coilysiren closed this Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants