V2 devlopment #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also introduces babel, react-bootstrap, new bundling scripts
configuration logic previously followed an implicit pattern. configuration items are now defined in a toml file and loaded in. config.js provides api to get and set configuration values, and contains audit log of where a value is coming from.
Adding mocha, chai, and istanbul to project. Writing initial config.js tests and making some config.js code updates because of it :)
building a new browserified.js should be part of the build process
fullpaths allows us to use disc/discify to visualize the contents of our browserified.js file (spoiler-alert it is react)
generally, config items are other set in the env/cli or via the app ui. This needs to be formalized eventually
a place to delay decisions
first pass at rewriting configuration ui and backend. More in line with the direction things are heading, but still needs some cleanup.
we should eventually be able to remove the pattern of passing the app object around and follow middleware and exporting router objects.
migrate-schema.js can help evolve data model over time fix signup rendering and logic (if user already has password set, user has already signed up)
it doesn’t seem so scary now
and add style for delete button
they’ve been re-implemented in react
this is handled by rendering special full-screen applets
If a value is number-like it should be converted to a number for min/max checking. If no value is null or undefined no further value inspection is necessary
Maybe make this something that can be turned off later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.