Skip to content

Conversation

@niting3c
Copy link
Contributor

Context

jira: https://transferwise.atlassian.net/browse/CONNECT-2653

  • This change helps us match the current envoy version 1.34.10-3 as well

Checklist

Copilot AI review requested due to automatic review settings December 29, 2025 16:27
@niting3c niting3c requested a review from a team as a code owner December 29, 2025 16:27
@platon-github-app-production
Copy link

Comment /request-review to automatically request reviews from the following teams:

You can also request review from a specific team by commenting /request-review team-name, or you can add a description with --notes "<message>"

💡 If you see something that doesn't look right, check the configuration guide.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades Gradle from version 7.4 to 8.11.1 and updates related components to align with envoy version 1.34.10-3. The changes include updates to the Gradle wrapper, build scripts, and various dependency versions.

  • Updates Gradle wrapper to version 8.11.1 with additional security properties
  • Upgrades gRPC and Protobuf versions to maintain compatibility
  • Updates Gradle plugins for protobuf, grgit, and nexus publishing
  • Adds configuration for duplicate handling and Javadoc warnings

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
gradle/wrapper/gradle-wrapper.properties Upgrades Gradle from 7.4 to 8.11.1 and adds network timeout and distribution URL validation
gradle/wrapper/gradle-wrapper.jar Updates wrapper JAR binary to match Gradle 8.11.1
gradlew Updates Unix wrapper script with improved error handling, shellcheck compliance, and SPDX license identifier
gradlew.bat Updates Windows wrapper script with improved error handling, better exit code management, and SPDX license identifier
gradle.properties Bumps version from 1.34.10-1 to 1.34.10-3 to match current envoy version
build.gradle Upgrades protobuf plugin (0.8.18→0.9.4), grgit plugin (4.1.1→5.2.2), nexus plugin (1.1.0→1.3.0), gRPC (1.45.1→1.54.1), and protobuf (3.20.1→3.21.12); adds duplicate strategy and Javadoc configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.4-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.11.1-bin.zip
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upgrade from Gradle 7.4 to 8.11.1 is a major version jump that may introduce breaking changes. Gradle 8 deprecated and removed several features that were present in Gradle 7. Since this is a major upgrade, ensure that all build scripts, plugins, and CI/CD pipelines have been tested thoroughly with the new Gradle version to verify there are no compatibility issues.

Suggested change
distributionUrl=https\://services.gradle.org/distributions/gradle-8.11.1-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.4-bin.zip

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants