Skip to content

Assignment1#1

Open
tqq199548 wants to merge 7 commits intomainfrom
assignment1
Open

Assignment1#1
tqq199548 wants to merge 7 commits intomainfrom
assignment1

Conversation

@tqq199548
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

@github-actions
Copy link

Autograder results

question status comment
1
2
3
4
5
6
7
8
9 coworker-changes branch not found in commit history

@github-actions
Copy link

Autograder results

question status comment
1
2
3
4
5
6
7 One or more files with ipaddr in data/raw not removed.; One or more files with ipaddr in data/processed/user_logs not removed
8 data/inventory.txt does not exist
9

@github-actions
Copy link

Autograder results

question status comment
1
2
3
4
5
6
7 One or more files with ipaddr in data/raw not removed.; One or more files with ipaddr in data/processed/user_logs not removed
8 data/inventory.txt does not exist
9

@github-actions
Copy link

Autograder results

question status
1
2
3
4
5
6
7
8
9

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

  1. In future, please add comments to the pull request as well.
  2. I noticed that assignment.sh file in your 'main' branch has diverged from the version in the forked repository. In a real project setup, the main branch is the stable, deployable version of the project, while branches isolate work for features, bug fixes, or experiments, ensuring main stays clean and reliable. Please try to update 'main' so that it doesn't have any of your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants