-
Notifications
You must be signed in to change notification settings - Fork 7
Replace parquet.js with hyparquet #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
|
@Nutlope? Anyone? |
|
This should be straightforward to review. |
|
Here's a video showing that instructions on together.ai website fail due to parquetjs parsing error. This PR fixes this issue: together-upload.mp4@Nutlope @samselikoff anything I can do to help move this along? |
|
@platypii thanks so much for reporting and for the PR! We're in the process of fixing some things with the upload. @yogishbaliga, mind taking at this PR when you do your other PR on the upload functionality too? |
|
@yogishbaliga thoughts? happy to contribute if there's more work that needs done |
BREAKING CHANGE: Access to fine tuning APIs namespace has changed from `fine_tune` to `fine_tuning`
…_checkpoints` BREAKING CHANGE: Access to the api for listing checkpoints has changed its name to `list_checkpoints`
…eng-48225-update-file-upload-setup-to-not-be-controlled-by-stainless feat(api): files.upload supported with custom file checks
BREAKING CHANGE: For the TS SDK the `images.create` is now `images.generate`
BREAKING CHANGE: Change Fine Tuning method name from `download()` to `content()` to align with other namespaces
BREAKING CHANGE: Update method signature for reranking to `rerank.create()`
|
@platypii apologies for the delay on this. I'm actively maintaining these codebases now. I switched the base branch to |
BREAKING CHANGE: Change call signature for `audio.create` to `audio.speech.create` to match spec with python library and add space for future APIs
994b18a to
2a5b13e
Compare
|
@blainekasten thanks, I just rebased onto FYI there seems to be an issue with installing packages in this repo. When I run Thanks! |
10df0df to
7e75fa7
Compare
Uses hyparquet for javascript parquet parsing. It is a small, pure js implementation of parquet parsing with no dependencies. Parquet.js that this replaces is unmaintained and has not been updated in 5+ years.
Fixes #102 and #104 by using a well-maintained parquet library that supports modern parquet files.
I tested this with the parquet file generated by
together-pythonand confirmed that upload works and fixes issue #104.Let me know if I can help with anything!
Note
Switches parquet parsing to hyparquet and updates parquet file checks to use hyparquet metadata/schema APIs.
_check_parquetinsrc/lib/check-file.tsto usehyparquet(asyncBufferFromFile,parquetMetadataAsync,parquetSchema) to read schema and row count.children.map(...name)and sample count viametadata.num_rows; removeparquetjsreader logic.hyparquet@1.14.0and removeparquetjsand its type definitions frompackage.json.Written by Cursor Bugbot for commit 6f1787b. This will update automatically on new commits. Configure here.