Skip to content

Conversation

@newokaerinasai
Copy link

@newokaerinasai newokaerinasai commented Dec 8, 2025

Note

Integrates fine-tuning price estimation into CLI and SDK create flows, displaying estimated cost and warnings for likely insufficient funds.

  • CLI (fine-tuning):
    • Integrates estimate_price before job submission; builds training_type/training_method params and shows estimated price in confirmation.
    • Adds red warning when funds likely insufficient; updates confirmation copy.
  • SDK/Resources:
    • create_finetune_request now returns (FinetuneRequest, TrainingType, TrainingMethod) for price estimation.
    • Adds create_price_estimation_params; create (sync/async) calls estimate_price pre-submit and prints warning if allowed_to_proceed is false.
  • Tests:
    • Update unit tests to unpack new return tuple from create_finetune_request.

Written by Cursor Bugbot for commit 4dfdf92. This will update automatically on new commits. Configure here.

@newokaerinasai newokaerinasai marked this pull request as ready for review December 9, 2025 00:15
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

price_estimation_result.estimated_total_price # pyright: ignore[reportPossiblyUnboundVariable]
)
+ "[/red]",
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way all of this logic could be put inside the create_finetune_request method?

This should be fine - but this file is generated, so I think minimizing code within this file while help avoid conflicts.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't access self within build_finetuning_request, perhaps any other way would cause conflicts in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants