-
Notifications
You must be signed in to change notification settings - Fork 0
add price estimation #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
add price estimation #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| price_estimation_result.estimated_total_price # pyright: ignore[reportPossiblyUnboundVariable] | ||
| ) | ||
| + "[/red]", | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way all of this logic could be put inside the create_finetune_request method?
This should be fine - but this file is generated, so I think minimizing code within this file while help avoid conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't access self within build_finetuning_request, perhaps any other way would cause conflicts in the future
Note
Integrates fine-tuning price estimation into CLI and SDK create flows, displaying estimated cost and warnings for likely insufficient funds.
estimate_pricebefore job submission; buildstraining_type/training_methodparams and shows estimated price in confirmation.create_finetune_requestnow returns(FinetuneRequest, TrainingType, TrainingMethod)for price estimation.create_price_estimation_params;create(sync/async) callsestimate_pricepre-submit and prints warning ifallowed_to_proceedis false.create_finetune_request.Written by Cursor Bugbot for commit 4dfdf92. This will update automatically on new commits. Configure here.