Skip to content
This repository was archived by the owner on Feb 4, 2023. It is now read-only.

Conversation

@acely
Copy link
Contributor

@acely acely commented Feb 12, 2018

Added translation for latest develop branch.

tofi86 and others added 28 commits September 29, 2017 23:59
log data from `syslog` command can be easily accessed with the `Console.app` utility by searching for *syslog*
test results:

########################################################
Testing function extractJavaMajorVersion()

Tests with Java 1.6:
[TEST OK] Extracted Java major version '6' for Java '1.6'
[TEST OK] Extracted Java major version '6' for Java '1.6+'
[TEST OK] Extracted Java major version '6' for Java '1.6.0'
[TEST OK] Extracted Java major version '6' for Java '1.6.0_07'
[TEST OK] Extracted Java major version '6' for Java '1.6.0_45'

Tests with Java 1.7:
[TEST OK] Extracted Java major version '7' for Java '1.7'
[TEST OK] Extracted Java major version '7' for Java '1.7*'
[TEST OK] Extracted Java major version '7' for Java '1.7.0'
[TEST OK] Extracted Java major version '7' for Java '1.7.0_09'
[TEST OK] Extracted Java major version '7' for Java '1.7.0_79'

Tests with Java 1.8:
[TEST OK] Extracted Java major version '8' for Java '1.8'
[TEST OK] Extracted Java major version '8' for Java '1.8+'
[TEST OK] Extracted Java major version '8' for Java '1.8.0'
[TEST OK] Extracted Java major version '8' for Java '1.8.0_05'
[TEST OK] Extracted Java major version '8' for Java '1.8.0_91'
[TEST OK] Extracted Java major version '8' for Java '1.8.0_131'

Tests with Java 9:
[TEST OK] Extracted Java major version '9' for Java '9'
[TEST OK] Extracted Java major version '9' for Java '9-ea'
[TEST OK] Extracted Java major version '9' for Java '9.1*'
[TEST OK] Extracted Java major version '9' for Java '9.0.1'
[TEST OK] Extracted Java major version '9' for Java '9.0.1+'
[TEST OK] Extracted Java major version '9' for Java '9.0.23'
[TEST OK] Extracted Java major version '9' for Java '9.10.120'
[TEST OK] Extracted Java major version '9' for Java '9.10.120+'
[TEST OK] Extracted Java major version '9' for Java '9.100.120+'

Tests with Java 10:
[TEST OK] Extracted Java major version '10' for Java '10'
[TEST OK] Extracted Java major version '10' for Java '10-ea'
[TEST OK] Extracted Java major version '10' for Java '10.1+'
[TEST OK] Extracted Java major version '10' for Java '10.0.1'
[TEST OK] Extracted Java major version '10' for Java '10.0.1*'
[TEST OK] Extracted Java major version '10' for Java '10.0.23'
[TEST OK] Extracted Java major version '10' for Java '10.10.120'
[TEST OK] Extracted Java major version '10' for Java '10.10.120+'
[TEST OK] Extracted Java major version '10' for Java '10.100.120+'
… // refs tofi86#47

the function now creates a 8 digit numeral from whatever form of Java version string or requirement string. See test results below for supported version strings

test results:

########################################################
Testing function JavaVersionSatisfiesRequirement()

Tests with Java 1.6:
[TEST OK] Version number '1.6' has comparable form '06000000' (matches expected result '06000000')
[TEST OK] Version number '1.6+' has comparable form '06000000' (matches expected result '06000000')
[TEST OK] Version number '1.6.0_45' has comparable form '06000045' (matches expected result '06000045')
[TEST OK] Version number '1.6.0_100' has comparable form '06000100' (matches expected result '06000100')
[TEST OK] Version number '1.6.1_87' has comparable form '06001087' (matches expected result '06001087')

Tests with Java 1.7:
[TEST OK] Version number '1.7.0_76' has comparable form '07000076' (matches expected result '07000076')
[TEST OK] Version number '1.7.0_144' has comparable form '07000144' (matches expected result '07000144')

Tests with Java 1.8:
[TEST OK] Version number '1.8' has comparable form '08000000' (matches expected result '08000000')
[TEST OK] Version number '1.8*' has comparable form '08000000' (matches expected result '08000000')
[TEST OK] Version number '1.8.0_98' has comparable form '08000098' (matches expected result '08000098')
[TEST OK] Version number '1.8.0_151' has comparable form '08000151' (matches expected result '08000151')

Tests with Java 9:
[TEST OK] Version number '9' has comparable form '09000000' (matches expected result '09000000')
[TEST OK] Version number '9+' has comparable form '09000000' (matches expected result '09000000')
[TEST OK] Version number '9-ea' has comparable form '09000000' (matches expected result '09000000')
[TEST OK] Version number '9.2' has comparable form '09002000' (matches expected result '09002000')
[TEST OK] Version number '9.2*' has comparable form '09002000' (matches expected result '09002000')
[TEST OK] Version number '9.0.1' has comparable form '09000001' (matches expected result '09000001')
[TEST OK] Version number '9.0.13' has comparable form '09000013' (matches expected result '09000013')
[TEST OK] Version number '9.1.3' has comparable form '09001003' (matches expected result '09001003')
[TEST OK] Version number '9.11' has comparable form '09011000' (matches expected result '09011000')
[TEST OK] Version number '9.10.23' has comparable form '09010023' (matches expected result '09010023')
[TEST OK] Version number '9.10.101' has comparable form '09010101' (matches expected result '09010101')

Tests with Java 10:
[TEST OK] Version number '10' has comparable form '10000000' (matches expected result '10000000')
[TEST OK] Version number '10*' has comparable form '10000000' (matches expected result '10000000')
[TEST OK] Version number '10-ea' has comparable form '10000000' (matches expected result '10000000')
[TEST OK] Version number '10.1' has comparable form '10001000' (matches expected result '10001000')
[TEST OK] Version number '10.1+' has comparable form '10001000' (matches expected result '10001000')
[TEST OK] Version number '10.0.1' has comparable form '10000001' (matches expected result '10000001')
[TEST OK] Version number '10.0.13' has comparable form '10000013' (matches expected result '10000013')
[TEST OK] Version number '10.1.3' has comparable form '10001003' (matches expected result '10001003')
[TEST OK] Version number '10.12' has comparable form '10012000' (matches expected result '10012000')
[TEST OK] Version number '10.10.23' has comparable form '10010023' (matches expected result '10010023')
[TEST OK] Version number '10.10.113' has comparable form '10010113' (matches expected result '10010113')
…avoid duplicate PlistBuddy calls

also: get rid of backtick `command` executions and use $() instead
function tests used spaces but all the rest of the script used tabs → convert all indents to tabs
See issue tofi86#51 for examples how to use this feature
Added translation for latest develop branch.
@acely
Copy link
Contributor Author

acely commented Feb 12, 2018

Oh not to the master...... My mistake,sorry again.

@acely acely closed this Feb 12, 2018
@tofi86 tofi86 added the invalid label Feb 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants