Skip to content

Conversation

@tlmitchell23
Copy link
Owner

Checkpoint Rubric

This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.

Checkpoint 1

  • All tests passed: 40 points
  • Proper use of documentation (commenting on code): 15 points
  • Properly indented code: 15 points
  • Demonstrated effective use of JavaScript: 30 points

Checkpoint 2

  • The application works as it should: 40 points
  • Proper use of documentation (commenting on code): 15 points
  • Properly indented code: 15 points
  • Demonstrated effective use of JavaScript and the DOM API: 30 points

Checkpoint 3

  • Use of React: 25 points
  • Accesses an API: 25 points
  • Proper use of documentation (commenting on code): 25 points
  • The application functions as it should: 25 points

Copy link

@reneemeyer reneemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty, nice job overall, the only thing I would suggest would be to simplify your code a bit and organize it into more concise functions as well as changes the functions to es6. Also, I would love to see some more commits :)

// color that was just selected by the player.
// Once 4 colors have been selected for the pegs we need to
// generate a hint.
displayRow: function() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be es6

}
},

showChoice: function(selectedColor) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be an es6 function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants