Unlimited Received Size in common tikv client#392
Closed
BoynChan wants to merge 1 commit intotikv:masterfrom
Closed
Unlimited Received Size in common tikv client#392BoynChan wants to merge 1 commit intotikv:masterfrom
BoynChan wants to merge 1 commit intotikv:masterfrom
Conversation
Collaborator
|
Thank you for your contribution! But I believe it's resolved by #399. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Due to limit received message size in Tikv default client (4MB), it's not enough for many applications that use it to store binary data. I unrestricted the receive message length by adding a option when creating ChannelBuilder.
Does it backward compatibility?
Yes, user will not be affected after changes.
Related Issue
#382
tikv/grpc-rs#602