[pull] master from jquast:master #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a blocking/synchronous interface for telnetlib3 and wait_for methods for telnet option negotiation. - **Deletes** the "_waiter_closed" future, this thing was a mistake and finally not necessary by new Server() - unfortunately _waiter_connected still exists and is used .. maybe that goes next - **New** Server.wait_for_clients() and other methods replaces need for _waiter_connected, closed, etc. - **New** writer.wait_for() to wait for specific option negotiation states (remote/local/pending), wait_for_condition() for custom predicates - **New** telnetlib3.sync module with TelnetConnection, BlockingTelnetServer, and ServerConnection classes for non-asyncio usage - Miniboa-compatible properties on ServerConnection for easier migration for "more advanced server of the same interface" - New docs/guidebook.rst with usage patterns and examples - Example scripts in bin/ (blocking client/server, wait_for demos) - Removed pylint.extensions.docparams (redundant with type annotations)
This also includes a performance-enhanced data_received on server end matching similar technique in client end, reducing loops/if statements and improving performance 50x or more
- Add new StatusLogger to server, count and report rx/tx bytes - update README.rst, main page hyperlinks to RTD often and overviews everything - rename pty module for better module namespace - reorganization of ``__all__`` for orderly ``help(telnetlib3)`` reading (like 4k lines! enjoy!!)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )