Skip to content

fixes: local variable 'response' referenced before assignment#170

Closed
lwille wants to merge 1 commit intothefactory:masterfrom
erasys:master
Closed

fixes: local variable 'response' referenced before assignment#170
lwille wants to merge 1 commit intothefactory:masterfrom
erasys:master

Conversation

@lwille
Copy link

@lwille lwille commented Feb 20, 2017

response won't be initialized in case an exception was thrown, causing the following error:

  File "/usr/local/lib/python2.7/site-packages/marathon/client.py", line 125, in _do_sse_request
    if response.ok:
UnboundLocalError: local variable 'response' referenced before assignment

@solarkennedy
Copy link
Contributor

Looks fine. Can you address the pep8 thing?

./marathon/client.py:129:9: E303 too many blank lines (2)

@solarkennedy
Copy link
Contributor

Month bump, can you address the flake errors? (optionally rebase on master)

@lwille
Copy link
Author

lwille commented Apr 10, 2019

closing outdated PR

@lwille lwille closed this Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants