Skip to content

Conversation

@rendrat
Copy link

@rendrat rendrat commented Dec 9, 2019

Updating the classpath build for com.android.tools.build:gradle to 3.5.2.

@googlebot googlebot added the cla: yes CLA has been signed label Dec 9, 2019
Copy link
Member

@jdduke jdduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why we need to change the image type? And why we need to upgrade gradle? Thanks.

@rendrat
Copy link
Author

rendrat commented Dec 10, 2019

Can you explain why we need to change the image type? And why we need to upgrade gradle? Thanks.

Thanks for responding to the pull request @jdduke.
Actually, the previous image was only providing info about "SCORE", the latest screenshot image that I commit, it has the "SCORE", which "DEVICE" Processor is being used and "Time" taken to process the pose segmentation.
And for build.gradle version 3.5.2, I think it has a few issues that already being fixed, and seem from my side when I try to build the project it runs faster then the previous build.gradle version 3.4.1.
Thanks @jdduke

Copy link
Member

@jdduke jdduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gradle change is fine, but we can't accept that reference image. Can you drop that and update the PR description? Thanks!

revert back the image from postnetimage.jpeg to postnetimage.png.
Deleting image postnetimage.jpeg
@rendrat rendrat changed the title Updating classpath build gradle and image README.md for posenet Android examples. Updating classpath build gradle to 3.5.2 from 3.4.1 Dec 11, 2019
@rendrat
Copy link
Author

rendrat commented Dec 11, 2019

The gradle change is fine, but we can't accept that reference image. Can you drop that and update the PR description? Thanks!

Ok @jdduke, may I know why is the image is being rejected, is it an inappropriate image?
I've already removed the image and put back the reference image to the original one.
Thanks

@jdduke
Copy link
Member

jdduke commented Dec 11, 2019

Yes, in general, we're quite conservative in terms of what images are allowed in our repo, making sure to have explicit permission from all relevant parties.

Copy link
Member

@jdduke jdduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change seems fine, but it's still not clear what the improvement is other than first time startup? All of our other examples use 3.4.1, as well, and we want to be consistent.

@jdduke
Copy link
Member

jdduke commented Dec 20, 2019

Friendly ping? I don't think we want to land this as a singleton while the other samples use 3.4.1. Some additional details on why we need the newer gradle version would be helpful. Thanks.

@jdduke jdduke closed this Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes CLA has been signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants