-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Updating classpath build gradle to 3.5.2 from 3.4.1 #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
updating with the master from tensorflow
jdduke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why we need to change the image type? And why we need to upgrade gradle? Thanks.
Thanks for responding to the pull request @jdduke. |
jdduke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gradle change is fine, but we can't accept that reference image. Can you drop that and update the PR description? Thanks!
revert back the image from postnetimage.jpeg to postnetimage.png.
Deleting image postnetimage.jpeg
Ok @jdduke, may I know why is the image is being rejected, is it an inappropriate image? |
|
Yes, in general, we're quite conservative in terms of what images are allowed in our repo, making sure to have explicit permission from all relevant parties. |
jdduke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change seems fine, but it's still not clear what the improvement is other than first time startup? All of our other examples use 3.4.1, as well, and we want to be consistent.
|
Friendly ping? I don't think we want to land this as a singleton while the other samples use 3.4.1. Some additional details on why we need the newer gradle version would be helpful. Thanks. |
Updating the classpath build for com.android.tools.build:gradle to 3.5.2.