Update replication task rate limiter priority based on active/standby… #8978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
commented
Jan 9, 2026
service/history/queues/scheduler.go
Outdated
| namespaceName = ns.Name().String() | ||
| } | ||
| if ns.ActiveInCluster(clusterMetadata.GetCurrentClusterName()) { | ||
| return quotas.NewRequest(e.GetType().String(), taskSchedulerToken, namespaceName, e.GetPriority().CallerType(), 0, "") |
service/history/queues/scheduler.go
Outdated
| if ns.ActiveInCluster(clusterMetadata.GetCurrentClusterName()) { | ||
| return quotas.NewRequest(e.GetType().String(), taskSchedulerToken, namespaceName, e.GetPriority().CallerType(), 0, "") | ||
| } else { | ||
| return quotas.NewRequest(e.GetType().String(), taskSchedulerToken, namespaceName, headers.CallerTypePreemptable, 0, "") |
Contributor
Author
There was a problem hiding this comment.
Use lowest level for standby tasks
yycptt
reviewed
Jan 12, 2026
service/history/queues/scheduler.go
Outdated
| } | ||
|
|
||
| return quotas.NewRequest(e.GetType().String(), taskSchedulerToken, namespaceName.String(), e.GetPriority().CallerType(), 0, "") | ||
| if ns.ActiveInCluster(clusterMetadata.GetCurrentClusterName()) { |
Member
There was a problem hiding this comment.
will this cause NPE if ns is nil?
Member
There was a problem hiding this comment.
hmm guess ideally we should only set priority once on creation and later when failover happens.
The whole activeness check for task processing probably needs to be refactored.
I think for now, can we move this logic into priority assigner and also update priority here?
service/history/queues/scheduler.go
Outdated
| rateLimiter SchedulerRateLimiter, | ||
| timeSource clock.TimeSource, | ||
| chasmRegistry *chasm.Registry, | ||
| clusterMetadata cluster.Metadata, |
Member
There was a problem hiding this comment.
shall we just pass in current cluster name here and avoid getting it from clusterMetadata for each task?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Update replication task rate limiter priority based on active/standby state
Why?
The replication task should have higher priority than standby task
How did you test it?
Potential risks
There is a task processing priority change requires review