Modernise and type-hint str2bool #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symonsoft
reviewed
May 24, 2025
pyproject.toml
Outdated
|
|
||
| [project.urls] | ||
| Homepage = "https://github.com/symonsoft/str2bool" | ||
| Download = "https://github.com/symonsoft/str2bool/tarball/1.1" |
symonsoft
reviewed
May 24, 2025
| Returns: | ||
| Optional[bool]: The converted boolean value, or None if the string cannot be converted and raise_exc is False. | ||
| """ | ||
| if isinstance(value, str): |
Owner
There was a problem hiding this comment.
ain't we loosing some backward compatibility?
symonsoft
reviewed
May 24, 2025
pyproject.toml
Outdated
| "License :: OSI Approved :: BSD License", | ||
| "Operating System :: OS Independent", | ||
| "Programming Language :: Python :: 2", | ||
| "Programming Language :: Python :: 2.7", |
Owner
There was a problem hiding this comment.
I'm not sure about the lower version
Author
|
@symonsoft thanks a lot for the review. I've had another go at this and finally realised that the type hints break python 2 compatibility! As a result I've updated the pyproject and code to reflect this. Python 3.7 is the oldest version I was able to run the test suite with so used this as base version. Let me know if there's anything else that needs improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modernises str2bool, adds tests and type hints. Also migrates from setup.* to UV.