Draft
Conversation
The ostream operator wasn't actually used anywhere, so we're good to accept fmt 9
Contributor
Author
|
Going to draft this because I can't confirm for sure that it works just yet |
Member
|
These types do all have ostream operators, and we do use fmtlib formatting on these types, so I expect it isn't possible to remove this like this. I think we need to drop support for fmtlib 8 and use the new custom formatters in fmtlib 9+ (and then we're compatible with all versions 9 and newer), I had this working a while ago but I haven't gotten back to merging it |
Contributor
Author
|
Oh, I see. I was grepping for use of the operator, not for operator overloading. My packaging efforts are currently stuck at symforce (I did test the previous PR outside of the build environment, and I guess I could do that here too, but I need to get this packaged anyway so that's my priority rn). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ostream operator wasn't actually used anywhere, so we're good to accept fmt 9.