Add unread tab (#1114) #1115
Open
Add unread tab (#1114) #1115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-okumura-isp
added a commit
to y-okumura-isp/knowledge
that referenced
this pull request
Jun 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1114
Add unread tab.
This PR has the following limitations.
For now, unread tab page lists at most PAGE_LIMIT(=50) knowledge articles at once.
In extreme cases, no article is shown even if there are some unread articles.
Reason:
KnowledgesDao.getUnreadKnowledgeIdssearches unread and non-private knowledges order by update_datetime.KnowledgesDaoselect 50 unread articles but all of them are protected, no article is shown.In this case, you need to click "next" button.
We can fix it by changing
SELECTsentences but I didn't because I feel it's a rare case.