Skip to content

Conversation

@zlayne
Copy link
Contributor

@zlayne zlayne commented Jan 14, 2026

📝 Summary

Ticket Summary (Title):
Fixes hidden/missing select options. And also updates the base InputSelect component to function more closely to PF Select components with typeahead & create functionality.

Ticket Link:
https://issues.redhat.com/browse/ACM-26304

Type of Change:

  • 🐞 Bug Fix
  • ✨ Feature
  • 🔧 Refactor
  • 💸 Tech Debt
  • 🧪 Test-related
  • 📄 Docs

✅ Checklist

General

  • PR title follows the convention (e.g. ACM-12340 Fix bug with...)
  • Code builds and runs locally without errors
  • No console logs, commented-out code, or unnecessary files
  • All commits are meaningful and well-labeled
  • All new display strings are externalized for localization (English only)
  • (Nice to have) JSDoc comments added for new functions and interfaces

If Feature

  • UI/UX reviewed (if applicable)
  • All acceptance criteria met
  • Unit test coverage added or updated
  • Relevant documentation or comments included

If Bugfix

  • Root cause and fix summary are documented in the ticket (for future reference / errata)
  • Fix tested thoroughly and resolves the issue
  • Test(s) added to prevent regression

🗒️ Notes for Reviewers

Signed-off-by: zlayne <zlayne@redhat.com>
Signed-off-by: zlayne <zlayne@redhat.com>
Signed-off-by: zlayne <zlayne@redhat.com>
Signed-off-by: zlayne <zlayne@redhat.com>
Signed-off-by: zlayne <zlayne@redhat.com>
Signed-off-by: zlayne <zlayne@redhat.com>
@zlayne
Copy link
Contributor Author

zlayne commented Jan 14, 2026

/retest

Signed-off-by: zlayne <zlayne@redhat.com>
Signed-off-by: zlayne <zlayne@redhat.com>
@zlayne
Copy link
Contributor Author

zlayne commented Jan 15, 2026

/retest

@zlayne zlayne requested a review from KevinFCormier January 15, 2026 13:18
Copy link
Contributor

@KevinFCormier KevinFCormier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zlayne. This is looking much better. As discussed, a few little things to fix:

  • WizSingleSelect needs the fix as well
  • Sometimes custom option is at the top of the list, and sometimes it is at the bottom (agreed to put at the top consistently)
  • Menu should open if not already open when user types into typeahead
  • Remove untranslated aria-labels if not needed; otherwise translate

Optional nice to have - add WizSelect with isCreatable and WizAsyncSelect with/without isCreatable examples to the demo Inputs wizard.

@KevinFCormier KevinFCormier changed the title 26304 fix wizard input select ACM-28640 fix wizard input select Jan 16, 2026
Signed-off-by: zlayne <zlayne@redhat.com>
Signed-off-by: zlayne <zlayne@redhat.com>
Signed-off-by: zlayne <zlayne@redhat.com>
Signed-off-by: zlayne <zlayne@redhat.com>
@openshift-ci openshift-ci bot added the lgtm label Jan 16, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinFCormier, zlayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [KevinFCormier,zlayne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link

@zlayne
Copy link
Contributor Author

zlayne commented Jan 17, 2026

/retest

2 similar comments
@zlayne
Copy link
Contributor Author

zlayne commented Jan 19, 2026

/retest

@zlayne
Copy link
Contributor Author

zlayne commented Jan 19, 2026

/retest

@KevinFCormier KevinFCormier merged commit d059000 into stolostron:main Jan 19, 2026
9 of 10 checks passed
@zlayne zlayne deleted the 26304-fix-wizard-input-select branch January 19, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants