-
Notifications
You must be signed in to change notification settings - Fork 109
ACM-28640 fix wizard input select #5457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACM-28640 fix wizard input select #5457
Conversation
Signed-off-by: zlayne <zlayne@redhat.com>
Signed-off-by: zlayne <zlayne@redhat.com>
Signed-off-by: zlayne <zlayne@redhat.com>
Signed-off-by: zlayne <zlayne@redhat.com>
Signed-off-by: zlayne <zlayne@redhat.com>
Signed-off-by: zlayne <zlayne@redhat.com>
|
/retest |
Signed-off-by: zlayne <zlayne@redhat.com>
Signed-off-by: zlayne <zlayne@redhat.com>
|
/retest |
KevinFCormier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zlayne. This is looking much better. As discussed, a few little things to fix:
- WizSingleSelect needs the fix as well
- Sometimes custom option is at the top of the list, and sometimes it is at the bottom (agreed to put at the top consistently)
- Menu should open if not already open when user types into typeahead
- Remove untranslated aria-labels if not needed; otherwise translate
Optional nice to have - add WizSelect with isCreatable and WizAsyncSelect with/without isCreatable examples to the demo Inputs wizard.
Signed-off-by: zlayne <zlayne@redhat.com>
Signed-off-by: zlayne <zlayne@redhat.com>
Signed-off-by: zlayne <zlayne@redhat.com>
Signed-off-by: zlayne <zlayne@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KevinFCormier, zlayne The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
/retest |
2 similar comments
|
/retest |
|
/retest |



📝 Summary
Ticket Summary (Title):
Fixes hidden/missing select options. And also updates the base InputSelect component to function more closely to PF Select components with typeahead & create functionality.
Ticket Link:
https://issues.redhat.com/browse/ACM-26304
Type of Change:
✅ Checklist
General
ACM-12340 Fix bug with...)If Feature
If Bugfix
🗒️ Notes for Reviewers