Skip to content

Pull from assignment to main#2

Open
stephaddams wants to merge 6 commits intomainfrom
assignment
Open

Pull from assignment to main#2
stephaddams wants to merge 6 commits intomainfrom
assignment

Conversation

@stephaddams
Copy link
Owner

UofT-DSI | GIT- Assignment 1

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Refactoring the existing assigments.sh script to perform all tasks needed and addig it to the repository.

What did you learn from the changes you have made?

How to modify an existing script. How to create directories, move files, and remove files with no absolute paths.
And how to manage versions changes on github.

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

I considered adding verifications to the script to let the user decide how to proceed and also to input the name of the project to match with the respective client project instead of just creating a "newproject" directory every time.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

The first time I did it I had an extra "rawdata" folder inside data that messed up the script once I ran it in another folder.
I had to re track the script steps and ran line by line to catch the error and update it on the script.

How were these changes tested?

I created another folder, copied the assigment.sh file and ran it inside that folder.
Then I proceeded to check the inventory file to verify that all files existed in the corresponding folders.
And lastly, I checked that there was no IP files on the folders.

Checklist

  • I can confirm that my changes are working as intended
  • I have tested the script with different folder locations and it works as expected.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autograder results

question status comment
Part 1 - Q1
Part 1 - Q2
Part 1 - Q3
Part 1 - Q4
Part 1 - Q5
Part 1 - Q6
Part 1 - Q7
Part 1 - Q8
Part 2 coworker-changes branch not found in commit history

Please address the issues listed above.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autograder results

question status
Part 1 - Q1
Part 1 - Q2
Part 1 - Q3
Part 1 - Q4
Part 1 - Q5
Part 1 - Q6
Part 1 - Q7
Part 1 - Q8
Part 2

Copy link

@xindizhang xindizhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done and great work! The assignment is complete, and no further changes are needed. Great PR descroption as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants