First template instanciation full argument parsing #99
Conversation
|
I modified azure-pipelines to add the needed jobs/steps to build with the new -DCPPAST_TEMPLATE_FULLARGUMENTSPARSING=ON option |
foonathan
left a comment
foonathan
left a comment
There was a problem hiding this comment.
Thanks a lot for doing it, appreciate it!
While I appreciate that you don't want to break existing users by guarding the feature behind a compile-time option, I prefer to be more aggressive with useful improvements such as this one. As such, I'd suggest you enable the option by default (with the intent to remove it eventually). I also don't think it is necessary to keep testing the old behavior.
src/libclang/type_parser.cpp
Outdated
| auto decl = clang_getTypeDeclaration(type); | ||
| auto count = clang_Type_getNumTemplateArguments(clang_getCursorType(decl)); | ||
| for (unsigned int index = 0 ; static_cast<int>(index) < count ; index++) { | ||
| CXType argType = clang_Type_getTemplateArgumentAsType(type,index); |
There was a problem hiding this comment.
What about non-type template parameters or template template parameters?
test/cpp_alias_template.cpp
Outdated
| builder.add_unexposed_arguments("void"); | ||
| REQUIRE(equal_types(idx, alias.type_alias().underlying_type(), *builder.finish())); | ||
| #else | ||
| // need to write the code for full argument parsing using add_argument |
There was a problem hiding this comment.
What do you mean by this comment?
There was a problem hiding this comment.
I didn't have the needed time to write the test for full argument parsing.
|
Sorry for the delay. The build and CI setup looks good, I'll merge it once, you've found the time to update tests and figure out what happens when you have non-type template parameters in there etc. |
2 participants
Hi Jonathan,
I wrote a first version for template instantiation full argument parsing in cppast.
I propose the code for review.
Note : I didn't add the proposal to have the choice between exposed or unexposed mode for arguments in this version.