Skip to content

Comments

First Commit#1

Open
ssimmswork wants to merge 4 commits intomasterfrom
Shian-Simms
Open

First Commit#1
ssimmswork wants to merge 4 commits intomasterfrom
Shian-Simms

Conversation

@ssimmswork
Copy link
Owner

No description provided.

@ssimmswork ssimmswork requested a review from adrianadames March 20, 2019 01:19
Copy link
Collaborator

@adrianadames adrianadames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're almost there Shian. I will merge the PR as soon as you get everything nested as I mentioned in a couple review comments.

background-color: #877EC1;
animation: colorChange 60s ease;
}
@media (min-width: 1000px) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These media queries should be nested in .container.

background-color: white;
}
}
.topContainer {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.topContainer should be nested under container. And then you can nest the img tag under topContainer.

align-self: center;
width: 100%;
}
@media (max-width: 500px) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nest media query under img. After doing all the nesting, it should look something like this:

.container{
	margin: auto;
	display:flex;
	justify-content: center;
	flex-direction: column;
	background-color:#877EC1;
	animation:colorChange 60s ease;
	
	@media @large{
		.maxWidth();
	}
	
	@media @mobile, @tablet{
		margin: 20px;
		animation: none;
		@media @mobile{
			background-color:white;
		}
	}

	.topContainer{
		display:flex;
		flex-direction: column;
		background-color: white;
		
		img{
			width: 100%;
			@media @mobile{
				width: 100%;
			}
		}
	}

Please have everything nested, including the elements in the

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants