Skip to content

Conversation

@jbtcd
Copy link

@jbtcd jbtcd commented Jul 1, 2025

PR Description

Add the excimer php extension to all of the docker images.
This extension is required to be able to do profiling with the help of sentry.
The extension is disabled by default and can be enabled like the blackfire, newrelic or pcov extension.

Steps before you submit a PR

  • Please add tests for the code you add if it's possible.
    • Its not possible for me to provide tests here, but I tested the image building and the combination to run a spryker application in the new containers.
  • Please check out our contribution guide: https://docs.spryker.com/docs/dg/dev/code-contribution-guide.html
  • Add a contribution-license-agreement.txt file with the following content:
    I hereby agree to Spryker\'s Contribution License Agreement in https://github.com/spryker/docker-php/blob/HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH/CONTRIBUTING.md.

This is a mandatory step to make sure you are aware of the license agreement and agree to it. HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH is a hash of the commit you are basing your branch from the master branch. You can take it from commits list of master branch before you submit a PR.

I don't get what do you want from me here, like in #116 i just seen that there is no CONTRIBUTING.md in this repository.

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

@jbtcd jbtcd force-pushed the master branch 2 times, most recently from 519b3fa to 9285948 Compare August 18, 2025 07:51
@jbtcd
Copy link
Author

jbtcd commented Oct 29, 2025

Hi @alexanderM91, could you please have a look into this PR?

@alexanderM91
Copy link
Collaborator

Hi @jbtcd,

I’ll check it on Monday.

Have a good weekend!

@alexanderM91
Copy link
Collaborator

Hi @jbtcd,

The extension will be released as part of #125, in line with our internal procedures and recent security fixes.

You can find the extension enablement documentation here: spryker/docker-sdk#580.

Thanks again for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants