This repository was archived by the owner on Apr 5, 2022. It is now read-only.
some refactorings and prevent possible nullpointer exception #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlicanAkkus Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@AlicanAkkus Thank you for signing the Contributor License Agreement! |
Author
|
@spencergibb hi, can you review pr and can you share your opinions with me? thanks. |
Contributor
|
@dsyer would be the one to review. |
Author
I'm waiting for your review :) |
|
LGTM. Lots of whitespace changes though. Maybe we should add the spring-format plugin. |
Author
I've added the format plugin and did reformat. |
Author
|
@dsyer @spencergibb hi, can you review again, please? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.