-
Notifications
You must be signed in to change notification settings - Fork 12
Add basic RT search support #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Result fetching callback handling is done this way to allow (future) progress tracking
Includes refactoring of prompt handling – side effects?
|
Thank you for this Martin! I am slammed right now with .conf next week, but I'll look into this. In the meanwhile, can you fill out our CLA here: http://www.splunk.com/goto/contributions? |
|
Some quick thoughts
I haven't looked yet at how you are doing the RT query with the SDK, but I'll take a look at everything. Also I'll be creating a develop branch you can submit your PR to. |
|
Updated this to block on RT searches until any key is pressed. |
|
Tested it out, looks great. Just looking through the code now. Thanks for your patience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is needed anymore as the realtime search exits before you get to the cmd prompt with your last change right?
Adds initial support for real-time searches (#6)
Open questions: