Skip to content

Conversation

@phutchins
Copy link

This attribute is often changed so the ability to customize with a default will be helpful.

@amirkdv
Copy link

amirkdv commented Nov 5, 2014

There already exists a directives attribute:

{
  "php": {
    "directives": {
      "post_max_size": "12M"
    }
  }
}

Which makes post_max_size = 12M appear at the bottom of your php.ini (see the template) overriding the line this PR fixes.

@phutchins
Copy link
Author

Ah good deal. Not used to seeing templates parsed like this. It seems a little dirty but I understand the attraction due to ease of keeping the template up to date through upstream changes... I'll close my pull request.

@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants