Merged
Conversation
There was a problem hiding this comment.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ✅ | |
| Part 1 - Q3 | ❌ | ls command not run |
| Part 1 - Q4 | ❌ | Missing directories: data/processed/server_logs, data/processed/user_logs, data/processed/event_logs |
| Part 1 - Q5 | ❌ | Missing files in data/processed/server_logs |
| Part 1 - Q6 | ❌ | Missing files in data/processed/user_logs; Missing files in data/processed/event_logs |
| Part 1 - Q7 | ❌ | One or more files with ipaddr in data/raw not removed. |
| Part 1 - Q8 | ❌ | data/inventory.txt does not exist |
| Part 2 | ❌ | coworker-changes branch not found in commit history |
Please address the issues listed above.
We processed
…into assignment Kept changes from both assignment and coworker-changes branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I am creating a bash script to organize and process the data. The script performs the following:
What did you learn from the changes you have made?
I learned how to use shell to interact with the file system on my computer. I learned to create directories and files, copy, move and delete files and folders. I also learned how to use wildcard to perform operations on multiple files at the same time.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Yes, I am still working on understanding the difference in commands when they end with a slash and when they don't. For some commands it does not seem to make a difference, whereas for others it does. I overcame those issues by testing my commands in the terminal one by one and making sure they are performing as expected. However, I haven't developed an intuitive understanding of the slash-at-end yet.
How were these changes tested?
The changes were tested by running each command one by one as well as by running the bash script locally to make sure it is making the changes as desired.
A reference to a related issue in your repository (if applicable)
Checklist