Skip to content

add exp to generateBearerToken options #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jadamduff wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add exp to generateBearerToken options #102

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ee7288
add exp to generateBearerToken options
jadamduff Mar 23, 2023
96a926e
fix expiryTime exp setting incorrectly
jadamduff Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/service-account/util/Token.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export type ResponseSignedDataTokens = { token: string, signedToken: string }
export type BearerTokenOptions = {
ctx?: string,
roleIDs?: string[],
exp?: number,
}

export type SignedDataTokensOptions = {
Expand Down Expand Up @@ -84,7 +85,7 @@ function getToken(credentials, options?: BearerTokenOptions): Promise<ResponseTo
printLog(errorMessages.NotAValidJSON, MessageType.ERROR);
throw new SkyflowError({ code: 400, description: errorMessages.NotAValidJSON });
}
const expiryTime = Math.floor(Date.now() / 1000) + 3600;
const expiryTime = Math.floor(Date.now() / 1000) + (options?.exp !== undefined ? Math.min(Math.max(options.exp), 1) : 3600);

const claims = {
iss: credentialsObj.clientID,
Expand Down