Skip to content

Conversation

@skyflow-vivek
Copy link
Collaborator

This PR contains changes for enhancing card brand choice behaviour, updated sample and CHANGELOG

Why

  • The card brand choice behaviour required some enhancements.
  • Now, the card icon for first option provided in scheme will be rendered in UI.
  • The sample is optimised for better performance.
  • The CHANGELOG is updated to keep track of all the changes.

Goal

  • This gives the flexibility to control the overall UX of card brand choice selection to the users.
  • Better sample for client use that is optimised and less prone to errors.
  • Updated CHANGELOG to keep track for all the changes.

Testing

  • Tested the changes manually
  • Modified existing unit tests to cover new changes

@github-actions
Copy link

Semgrep findings: No issues found, Good to merge.

@github-actions
Copy link

Semgrep findings: No issues found, Good to merge.

@skyflow-vivek skyflow-vivek changed the title Release/25.4.2 SK-1990/Release/25.4.2 Apr 14, 2025
@skyflow-vivek skyflow-vivek reopened this Apr 14, 2025
@github-actions
Copy link

Semgrep findings: No issues found, Good to merge.

@skyflow-vivek skyflow-vivek merged commit fa727cb into main Apr 14, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants