fix: link preview generation after acceptance and blinking issue #1725
+223
−188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR refactors link preview functionality to fix issues with link preview generation after user acceptance and to resolve a blinking issue. The changes extract link preview logic from CompositionBox into a standalone component with improved state management and caching.
Key Changes:
- Added optional callback to
showLinkSharingConfirmationModalDialogto enable link previews on user acceptance - Refactored link preview logic into
SessionStagedLinkPreviewcomponent with a newPreviewFetchclass and caching mechanism - Introduced
enabledLinkPreviewsDuringLinkPastestate to handle link preview generation after user accepts the setting
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| ts/interactions/conversationInteractions.ts | Added optional onOk callback parameter to enable link previews upon user confirmation |
| ts/components/conversation/composition/CompositionBox.tsx | Removed link preview logic, added state flag for paste-triggered preview enablement, passes draft and flag to SessionStagedLinkPreview |
| ts/components/conversation/SessionStagedLinkPreview.tsx | Complete refactor with PreviewFetch class, module-level cache Map, and hook-based state management for link preview fetching and display |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Aerilym
force-pushed
the
fix/add_image_processing_alternative
branch
from
2dd7e57 to
12ad9d4
Compare
Aerilym
force-pushed
the
fix/refactor_link_previews
branch
from
e4f2e98 to
6972b34
Compare
Aerilym
changed the base branch from
fix/add_image_processing_alternative
to
dev
Bilb
previously approved these changes
Dec 2, 2025
| draft: string; | ||
| enabledLinkPreviewsDuringLinkPaste: boolean; | ||
| }; | ||
| export const SessionStagedLinkPreview = (props: Props) => { |
Bilb
previously approved these changes
Dec 3, 2025
Aerilym
force-pushed
the
fix/refactor_link_previews
branch
from
300b2b1 to
0d8b43e
Compare
Bilb
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.