SES-1971 : Enable minification #1566
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/build.gradle.kts
Outdated
| isDefault = true | ||
| isMinifyEnabled = false | ||
|
|
||
| isMinifyEnabled = true |
Collaborator
There was a problem hiding this comment.
We shouldn't have anything set on debug as it should run without minification and obfuscation
Collaborator
|
There are some repeated lines for jackson and a few redundant declarations throughout where -keep already does a lot of the work repeated in other lines. |
app/build.gradle.kts
Outdated
| getByName("debug") { | ||
| isDefault = true | ||
| isMinifyEnabled = false | ||
| proguardFiles( |
Collaborator
There was a problem hiding this comment.
This can be removed in debug since we are not using R8 on debug builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SES-1971
Initial minification and proguard rules setup.