made caesar by TimofeyLuk · Pull Request #36 · secourse2019/workrep

TimofeyLuk · 2019-10-30T17:37:13Z

No description provided.

ghost · 2019-10-30T17:37:58Z

The Checkstyle analysis for the commit ec98eab failed. ⛑
Visit the analysis result or the error log for more details.

ghost · 2019-10-30T17:37:59Z

The JavaSee analysis for the commit ec98eab failed. ⛑
Visit the analysis result or the error log for more details.

ghost · 2019-10-30T17:38:20Z

PMD detected 7 issues on the commit ec98eab.
Visit the analysis result to review all issues.

ghost · 2019-10-30T17:45:38Z

The JavaSee analysis for the commit bbf89b0 failed. ⛑
Visit the analysis result or the error log for more details.

ghost · 2019-10-30T17:45:39Z

The Checkstyle analysis for the commit bbf89b0 failed. ⛑
Visit the analysis result or the error log for more details.

ghost · 2019-11-01T06:49:24Z

The JavaSee analysis for the commit 5c02044 failed. ⛑
Visit the analysis result or the error log for more details.

ghost · 2019-11-01T06:49:24Z

src/main/java/com/t795/zki/ciphers/Caesar.java

+public class Caesar implements SystemCaesar {
+
+        private String message;
+        private char[] instance;


[PMD] Found non-transient, non-static member. Please mark as transient or provide accessors. (see on Sider)

Details

References:

https://pmd.github.io/pmd-6.18.0/pmd_rules_java_errorprone.html#beanmembersshouldserialize

ghost · 2019-11-01T06:49:25Z

The Checkstyle analysis for the commit 5c02044 failed. ⛑
Visit the analysis result or the error log for more details.

ghost · 2019-11-01T06:49:25Z

src/main/java/com/t795/zki/ciphers/Caesar.java

+
+public class Caesar implements SystemCaesar {
+
+        private String message;


[PMD] Avoid unused private fields such as 'message'. (see on Sider)

Details

References:

https://pmd.github.io/pmd-6.18.0/pmd_rules_java_bestpractices.html#unusedprivatefield

ghost · 2019-11-01T06:49:26Z

src/main/java/com/t795/zki/ciphers/Caesar.java

+
+public class Caesar implements SystemCaesar {
+
+        private String message;


[PMD] Found non-transient, non-static member. Please mark as transient or provide accessors. (see on Sider)

Details

References:

https://pmd.github.io/pmd-6.18.0/pmd_rules_java_errorprone.html#beanmembersshouldserialize

ghost · 2019-11-01T06:57:14Z

The Checkstyle analysis for the commit 70c4e51 failed. ⛑
Visit the analysis result or the error log for more details.

ghost · 2019-11-01T06:57:14Z

The JavaSee analysis for the commit 70c4e51 failed. ⛑
Visit the analysis result or the error log for more details.

ghost · 2019-11-01T07:44:31Z

The JavaSee analysis for the commit 4afa3d3 failed. ⛑
Visit the analysis result or the error log for more details.

ghost · 2019-11-01T07:44:31Z

Checkstyle detected 61 issues on the commit 4afa3d3.
Visit the analysis result to review all issues.

ghost · 2019-11-01T07:44:31Z

src/main/java/com/t795/zki/common/cipher/SystemCaesar.java

@@ -1,24 +1,9 @@
 package com.t795.zki.common.cipher;

+import com.sun.org.apache.xpath.internal.operations.String;


[PMD] Avoid unused imports such as 'com.sun.org.apache.xpath.internal.operations.String' (see on Sider)

Details

References:

https://pmd.github.io/pmd-6.18.0/pmd_rules_java_bestpractices.html#unusedimports

ghost · 2019-11-01T07:44:32Z

src/main/java/com/t795/zki/ciphers/Caesar.java

+public class Caesar implements SystemCaesar {
+
+        private String message;
+        private int delta;


[PMD] Found non-transient, non-static member. Please mark as transient or provide accessors. (see on Sider)

Details

References:

https://pmd.github.io/pmd-6.18.0/pmd_rules_java_errorprone.html#beanmembersshouldserialize

ghost · 2019-11-01T08:00:10Z

The JavaSee analysis for the commit b2cb7a6 failed. ⛑
Visit the analysis result or the error log for more details.

ghost · 2019-11-01T08:03:51Z

The JavaSee analysis for the commit 9676a2f failed. ⛑
Visit the analysis result or the error log for more details.

ghost · 2019-11-01T08:20:08Z

The JavaSee analysis for the commit 9eaa345 failed. ⛑
Visit the analysis result or the error log for more details.

ghost · 2019-11-01T08:20:08Z

src/main/java/com/t795/zki/ciphers/Caesar.java

+            int number = ((int)instance[index] + value);
+            int lastCharacter = (int)'\uFFEF';
+
+            if (number > lastCharacter) {


[Checkstyle] 'if' has incorrect indentation level 12, expected level should be 4. (see on Sider)

ghost · 2019-11-01T08:22:16Z

The JavaSee analysis for the commit 46284ad failed. ⛑
Visit the analysis result or the error log for more details.

ghost · 2019-11-01T08:25:06Z

The JavaSee analysis for the commit 5c0ec96 failed. ⛑
Visit the analysis result or the error log for more details.

ghost · 2019-11-01T08:31:35Z

The JavaSee analysis for the commit 3d8a9f4 failed. ⛑
Visit the analysis result or the error log for more details.

ghost · 2019-11-01T08:33:19Z

The JavaSee analysis for the commit a1b4af4 failed. ⛑
Visit the analysis result or the error log for more details.

made caesar

ec98eab

]

bbf89b0

TimofeyLuk added 2 commits November 1, 2019 09:36

changes

3c7bbcb

change caesar

5c02044

ghost reviewed Nov 1, 2019

View reviewed changes

new commit

70c4e51

caesar

4afa3d3

ghost reviewed Nov 1, 2019

View reviewed changes

git ignore

b2cb7a6

git ignore v2

9676a2f

TimofeyLuk added 2 commits November 1, 2019 11:14

commit

dbd869c

commit

9eaa345

ghost reviewed Nov 1, 2019

View reviewed changes

commit

46284ad

commit

5c0ec96

commit

3d8a9f4

commit

a1b4af4


		public class Caesar implements SystemCaesar {

		private String message;

		@@ -1,24 +1,9 @@
		package com.t795.zki.common.cipher;

		import com.sun.org.apache.xpath.internal.operations.String;

Conversation

TimofeyLuk commented Oct 30, 2019

Uh oh!

ghost commented Oct 30, 2019

Uh oh!

ghost commented Oct 30, 2019

Uh oh!

ghost commented Oct 30, 2019

Uh oh!

ghost commented Oct 30, 2019

Uh oh!

ghost commented Oct 30, 2019

Uh oh!

ghost commented Nov 1, 2019

Uh oh!

ghost Nov 1, 2019

Choose a reason for hiding this comment

Uh oh!

ghost commented Nov 1, 2019

Uh oh!

ghost Nov 1, 2019

Choose a reason for hiding this comment

Uh oh!

ghost Nov 1, 2019

Choose a reason for hiding this comment

Uh oh!

ghost commented Nov 1, 2019

Uh oh!

ghost commented Nov 1, 2019

Uh oh!

ghost commented Nov 1, 2019

Uh oh!

ghost commented Nov 1, 2019

Uh oh!

ghost Nov 1, 2019

Choose a reason for hiding this comment

Uh oh!

ghost Nov 1, 2019

Choose a reason for hiding this comment

Uh oh!

ghost commented Nov 1, 2019

Uh oh!

ghost commented Nov 1, 2019

Uh oh!

ghost commented Nov 1, 2019

Uh oh!

ghost Nov 1, 2019

Choose a reason for hiding this comment

Uh oh!

ghost commented Nov 1, 2019

Uh oh!

ghost commented Nov 1, 2019

Uh oh!

ghost commented Nov 1, 2019

Uh oh!

ghost commented Nov 1, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant