Open
Conversation
branchwelder
reviewed
Oct 4, 2016
branchwelder
left a comment
There was a problem hiding this comment.
In the future you should do your projects in python files, because we can't review jupyter notebooks easily.
General comments:
- Good layout
- Variable names were not as descriptive as they should have been. It helps readability a lot when you use descriptive variable names, even in for loops. For example: instead of "for i in thing" use "for what_the_value_is in thing"
- It's also best practice to import everything at the top of the file, not throughout the code (although this could be because you were working in a jupyter notebook)
| @@ -0,0 +1,115 @@ | |||
| { | |||
There was a problem hiding this comment.
I realized that I can't leave comments on a jupyter notebook, so in the future you should do your projects in python files. It's also helpful to have something that you can run from the command line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.