Skip to content

Add files via upload#6

Open
agrant4 wants to merge 1 commit intosd16fall:masterfrom
agrant4:master
Open

Add files via upload#6
agrant4 wants to merge 1 commit intosd16fall:masterfrom
agrant4:master

Conversation

@agrant4
Copy link

@agrant4 agrant4 commented Oct 3, 2016

No description provided.

Copy link

@branchwelder branchwelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future you should do your projects in python files, because we can't review jupyter notebooks easily.

General comments:

  • Good layout
  • Variable names were not as descriptive as they should have been. It helps readability a lot when you use descriptive variable names, even in for loops. For example: instead of "for i in thing" use "for what_the_value_is in thing"
  • It's also best practice to import everything at the top of the file, not throughout the code (although this could be because you were working in a jupyter notebook)

@@ -0,0 +1,115 @@
{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that I can't leave comments on a jupyter notebook, so in the future you should do your projects in python files. It's also helpful to have something that you can run from the command line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants