Turning in Eric's mini project 1

[lqyeric94]

No description provided.

[runnersaw]

This review is intended to help you with writing readable and understandable code, not to evaluate or improve the functionality of your code.

In addition to the comments I made below, improving the names of your variables to allow a user to see what they are would be good.

[runnersaw]

You can move the declaration of the variable to the line before you process them, such as:

christianity=URL("http://www.gutenberg.org/cache/epub/8294/pg8294.txt").download()
process_file(christianity)

This improves the readability of your code by grouping related things.

[runnersaw]

Best practice is to not put a space before the square brackets here.

[runnersaw]

It would be good to add a comment describing what this function does at the top of the function, such as:

def process_file(file):
    '''
    This function does something blah blah
    '''
    code here...

[runnersaw]

This is some final feedback about your project.

Overall, your report answered every question that was asked of you. Your answers were somewhat short, but given the brevity of the code and the scope of the project, I’m not sure that there was much more for you to say.

The code runs without modification. However, there is a mistake where you do the following:

   for a,b in le:
        return b

This means that it only returns the top result, rather than printing or returning the top number of results. Changing this to a print, or printing le solves this issue rather simply.

There isn’t a single comment or docstring in your code.

Your code is minimal and organized well. Variable names could use improvement. You redefine a function unnecessarily (you can define the function once, and then use it multiple times).